Use ffmpeg resampling to handle non-standard sample rates #303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@happycube - can you verify this and pull it in? Doesn't look like a change that is risky |
atsampson
force-pushed
the
freqconv
branch
2 times, most recently
from
0d46de9
to
52d0710
Compare
When -f is specified, load the input file through ffmpeg using the aresample filter to convert to 40MHz. This means the rest of ld-decode can run at its usual sample rate, which produces better-quality results and makes testing easier in the future.
This avoids a broken-pipe warning from ffmpeg when using -l. (Strictly this will only work properly in CPython, since other implementations like PyPy don't guarantee the destructor will actually be run. Fixing this properly would mean changing the loader interface to have an explicit close() operation.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems to work pretty well - I've tried it with a number of 8fSC captures and it produces better results than running the rest of the decoder at 8fSC. It should simplify future testing as well.
The script i used to test this with a few different input formats is here.
There's probably enough loader code in lddutils to make it worth moving into a module of its own now (lddecode.loaders?).