Add regression tests using GitHub CI #382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Given an RF input file, this runs it through the complete decoding toolchain, and does optional sanity checks on the results. It's careful to run all the tools from the source directory, so you don't need to install anything first.
On pushes and pull requests, this builds all of ld-decode, and runs test-decode on CAV/CLV PAL/NTSC samples from ld-decode-testdata. The sanity check parameters are based on the results as of the rev6 release (with bPSNR backed off by 0.5 dB to allow for some variation).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
test-decodescript, and a GitHub CI configuration that invokes it automatically on pushes and pull requests. The following things are tested:It also does some basic sanity checks on the output: the black PSNR, number of frames decoded and number of EFM samples decoded shouldn't be significantly worse than they currently are, and some VBI data should be decoded correctly (thanks @simoninns for some suggestions here!).
We could add extra unit tests and decoding samples easily in the future.
The
test-decodescript should be useful on its own during development. I've made it a separate commit so that if the CI config turns out to be problematic we can just revert the second commit.Here's a sample run of the tests.
Fixes #374 and related to #8.