Fix initial offset logic in findPotentialReplacementLines #515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The multi-source changes altered this so that it was only applied for the first source -- but it's there to ensure that we only find replacement lines that have the correct same phase, so it's necessary for all sources.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The multi-source changes altered this so that it was only applied for the first source -- but it's there to ensure that we only find replacement lines that have the correct same phase, so it's necessary for all sources.
Fixes #514 (where on frame 4 it was replacing line 146 with line 146 from the other field, which has the opposite chroma phase).