Fix some compiler warnings #734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atsampson
added
enhancement
ld-decode-tools
|
Failing CI @atsampson - please verify |
Qt 6.1 deprecates some of QScopedPtr's API, and recommends using unique_ptr instead. (Note that since this code is built as C++11 with Qt 5, we can't use C++14's std::make_unique yet, but that would be worthwhile in the future.)
GCC warned about an signed/unsigned comparison here. After testing, this revealed that the logic to work out how much of a frame to skip when seeking wasn't correct, meaning it always output the whole frame (although fortunately this doesn't make much difference for ld-decode/ld-cut's purposes!). Rewrite the code to avoid the signed/unsigned confusion and skip the right amount of data.
lineLen wasn't being used, and isn't needed (checked by comparison with BBC subcarrier-locked samples).
|
This turned out to be another bug that fixing the comparison revealed - so I've included a fix for that as well... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of QScopedPointer's API is deprecated in favour of std::unique_ptr in Qt 6.1; use std::unique_ptr instead.
Avoid a signed/unsigned comparison in ld-ldf-reader. Edit: with CI, this revealed a fault in the seeking logic - fixed.
Remove some dead code in ld-chroma-encoder. (I had to do some testing to convince myself it really wasn't needed; separate PR coming to add the test.)