Remove the mode option from the Transform decoders #776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atsampson
added
enhancement
ld-decode-tools
|
This change is conflicting with one of the last few ones, needs updating before I can commit. |
There doesn't appear to be any reason to use level mode (the BBC hardware decoders use threshold mode), so removing the option simplifies both the code and the interface.
|
Rebased - should be good now. |
|
Updated the ld-analyse and ld-chroma-decoder pages on the wikl for this and the other recent changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There doesn't appear to be any reason to use level mode (the BBC hardware decoders use threshold mode), so removing the option simplifies both the code and the interface.
Note to self: update the wiki.