First CMake files #780
First CMake files #780
Conversation
Current flaws: The thing only works on Linux, and library install locations are manually set to /usr/lib64 ld-analyse requires modifications to the makefile to compile FindQWT code and ld-analyse code currently occupy the same CMakeLists.txt file.
|
I'm still on Ubutu 20.04, this doesn't work for me: " |
|
@happycube is it possible to upgrade to CMake 3.22 on your machine? |
There was a problem hiding this comment.
This isn't a detailed review, but a few comments from a first look through this...
The GitHub CI config needs updating to build the project with CMake - you should be able to copy the one from DomesdayDuplicator, which builds on both the oldest and newest versions of Ubuntu (do it with Qt 5 only for now).
The test rules from the top-level Makefile need converting to CMake tests - this should be easy enough since they're all just running a command and checking it exits 0.
CMakeLists.txt
Outdated
| # Include all the paths | ||
| message( STATUS "--------- Finding packages---------") | ||
|
|
||
| find_package(Qt5 REQUIRED COMPONENTS Core) |
There was a problem hiding this comment.
I'd definitely get it working with Qt 5 first, but we will need Qt 6 support as well (see the DomesdayDuplicator commits for how we handled it there without needing to make too much stuff conditional).
|
@atsampson I will make those changes tonight and test them before committing |
Phasing out FindQWT module
Restored old Makefile
I don't see any evidence that this is needed.
Only ld-process-efm needs this, since it has headers in subdirs.
This is based on what gnuradio does.
Without this, it won't actually pass -std= to the compiler.
This largely follows what gnuradio does -- there is a single project() for the whole thing, and the subdirs just declare targets within it.
This follows gnuradio's conventions.
I've put these in a separate file since they're quite long.
Verified to work on Ubuntu and Manjaro
Use gnuradio's FindQwt module (slightly modified).
|
After some collaboration, it works with nearly every Linux distro I tested, no source code tweaking required! Working:
Not working: Slackware 15.0 UPDATE: I have declared it to difficult to support Slackware (unless we distribute binaries, or don't update library versions until Slackware catches up) |
Only the lddecode-chroma library needs it, and it should use the result of pkgconfig rather than specifying the name directly.
It looks like nearly all distributions that ship a recent Qwt also include the pkgconfig file -- the only one I've tested that doesn't is FreeBSD, which was broken anyway.
More CMake work
Fixes #769
Plus new gitignore parameters for CMake-generated files, It's a good start.
Current flaws:
Fixed flaws:
-ld-analyse requires modifications to the generated Makefile to compileFixed (on Ubuntu at least)