feat: collapsible menu #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for astonishing-pothos-5f81bd ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
shootermv
force-pushed
the
collapsible-menu
branch
5 times, most recently
from
e71aa16
to
73b41cb
Compare
NoamGaash
approved these changes
Nov 14, 2023
NoamGaash
approved these changes
Nov 15, 2023
shootermv
force-pushed
the
collapsible-menu
branch
from
6004fba
to
8a77149
Compare
shootermv
force-pushed
the
collapsible-menu
branch
3 times, most recently
from
cfaecf3
to
1a2b33e
Compare
shootermv
force-pushed
the
collapsible-menu
branch
from
1a2b33e
to
e1b178c
Compare
|
Need to set the width to 220px, also after the app is rendered the opening/ closing of the sider is very slow :) |
|
@xoRmalka @shootermv it's already merge, so feel pree to open issue or another PR if needed |
This was referenced Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
at desktop, side menu has
collapsible menutoggle at its bottomcloses #207
screenshots
expanded mode:
collapsed mode: