feat: add support for dark & light themes #335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shootermv
force-pushed
the
dark-light-themes-support-
branch
7 times, most recently
from
4789864
to
ee6bfe2
Compare
NoamGaash
reviewed
Dec 24, 2023
shootermv
force-pushed
the
dark-light-themes-support-
branch
from
6c935f1
to
5dad22d
Compare
Co-authored-by: NoamGaash <noam.gaash@gmail.com>
shootermv
force-pushed
the
dark-light-themes-support-
branch
from
1099c57
to
de53e78
Compare
shootermv
force-pushed
the
dark-light-themes-support-
branch
from
de53e78
to
9e546b8
Compare
|
@shootermv I might confuse stuff and I might miss somehting, but it seems like you are already filling dates - maybe fillDate is useless for this case? |
|
Totally right, thanks |
NoamGaash
approved these changes
Dec 25, 2023
Comment on lines
+7
to
+9
| .main-header.dark { | ||
| background: #141414; | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
add dark & light theme toggle at topbar
lot of modern designs has such toggle
closes #336
screenshots
dark desktop:
light desktop:
dark mobile:
light mobile: