Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add tooltips to homepage icons and restructure icons for responsive design #827

Merged
merged 1 commit into from
Jun 20, 2024

Conversation

Sicnecher
Copy link
Collaborator

  1. The explanations for each icon were occupying too much space, so I implemented a solution using tooltips.
    צילום מסך 2024-06-20 000057

צילום מסך 2024-06-20 000324
3. When the screen width is below 320px, the icons start glitching to the sides, making them difficult to access for phone users and visually unappealing. Instead, once the screen width reaches 450px, the icons are replaced with a single menu icon that provides quick access to the menu for browsing.
צילום מסך 2024-06-20 000132
צילום מסך 2024-06-20 000253

P.S.: Just to clarify, the noticeable changes in the last part of the file are due to the fact that I have moved the non-React functions above. After all, it's best practice.

Copy link
Member

@NoamGaash NoamGaash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@Sicnecher Sicnecher merged commit 783d32e into main Jun 20, 2024
15 of 17 checks passed
@Sicnecher Sicnecher deleted the homepage-change branch June 20, 2024 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants