Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing hover for count and for_each expression #166

Merged
merged 3 commits into from
Nov 30, 2022

Conversation

dbanck
Copy link
Member

@dbanck dbanck commented Nov 28, 2022

This PR adds the extension-based schema changes for count and for_each during reference origin collection. This error occurred because we collected no origins for var.name.

Before

CleanShot 2022-11-28 at 16 51 30@2x

CleanShot 2022-11-28 at 16 51 02@2x

After

CleanShot 2022-11-30 at 11 14 48@2x

CleanShot 2022-11-30 at 11 15 31@2x

@dbanck dbanck added the bug Something isn't working label Nov 28, 2022
@dbanck dbanck force-pushed the b-missing-hover-foreach-count branch from ccf69a8 to 22775e5 Compare November 30, 2022 10:14
@dbanck dbanck requested a review from a team November 30, 2022 10:18
@dbanck dbanck self-assigned this Nov 30, 2022
@dbanck dbanck marked this pull request as ready for review November 30, 2022 10:18
Copy link
Member

@radeksimko radeksimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm guessing this was lost in the large dynamic PR somewhere, when we have made the origin collection stricter, right?

Either way, nice fix! 👍🏻 🚢

@dbanck
Copy link
Member Author

dbanck commented Nov 30, 2022

Yeah, the changes introduced in #155 require a valid collected origin for hover now. And we never created one for count and for_each.

@dbanck dbanck merged commit 2b1ae40 into main Nov 30, 2022
@dbanck dbanck deleted the b-missing-hover-foreach-count branch November 30, 2022 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants