Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

decoder: Add support for Object as Constraint #203

Merged
merged 7 commits into from
Mar 15, 2023
Merged

Conversation

radeksimko
Copy link
Member

@radeksimko radeksimko commented Feb 10, 2023

Part of hashicorp/terraform-ls#496

Depends on #230


Existing tests were updated as part of fd9193b (not part of this PR) and yield either comparable or better results, except for reference collection, which:

  • we agreed to leave for a separate PR
  • involves other constraints which aren't implemented yet

UX

(with pre-filling required attributes)

2023-03-14 19 01 43

2023-03-14 19 03 12

(without pre-filling required attributes)

2023-03-14 19 07 16

2023-03-14 19 07 40

@radeksimko radeksimko marked this pull request as ready for review March 15, 2023 08:13
@radeksimko radeksimko requested a review from a team as a code owner March 15, 2023 08:13
Copy link
Member

@dbanck dbanck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great and thanks for testing all the edge cases 👍

I only stumbled across two small things.

decoder/expr_object_completion.go Outdated Show resolved Hide resolved
decoder/expr_object_completion.go Outdated Show resolved Hide resolved
radeksimko and others added 2 commits March 15, 2023 10:56
Co-authored-by: Daniel Banck <dbanck@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants