Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schema based validation #294

Merged
merged 21 commits into from
Aug 8, 2023
Merged

Schema based validation #294

merged 21 commits into from
Aug 8, 2023

Conversation

jpogran
Copy link
Contributor

@jpogran jpogran commented Aug 2, 2023

  • extraneous block labels - e.g. variable "one" "two" {
  • missing block labels - e.g. variable {}
  • unknown blocks (top level and within resources)
  • missing required attributes
  • unknown attributes
  • missing required blocks (with set minimum instances of block)
  • too many blocks (with set maximum instances of block)
  • deprecated attributes/blocks (warning)

@jpogran jpogran self-assigned this Aug 2, 2023
@jpogran jpogran changed the title schema based validation Schema based validation Aug 2, 2023
@jpogran jpogran linked an issue Aug 4, 2023 that may be closed by this pull request
8 tasks
@jpogran jpogran marked this pull request as ready for review August 7, 2023 19:00
@jpogran jpogran requested a review from a team as a code owner August 7, 2023 19:00
Copy link
Member

@radeksimko radeksimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed a minor change in the last commit to aid readability but otherwise it LGTM at this point. There's more work to do on readability/composition but we can do that as part of another PR.

@radeksimko radeksimko merged commit 1828ecd into main Aug 8, 2023
5 checks passed
@radeksimko radeksimko deleted the schema_based_validation branch August 8, 2023 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

decoder: Implement validateBody
3 participants