Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: asynchronous loading of root module parts #219

Merged
merged 4 commits into from
Jul 9, 2020
Merged

refactor: asynchronous loading of root module parts #219

merged 4 commits into from
Jul 9, 2020

Conversation

radeksimko
Copy link
Member

@radeksimko radeksimko commented Jul 8, 2020 •
edited
Loading

Closes #195

Closes #219

I also believe this solves #211 but I would like to gate the fmt availability on version, or at least better understand what happens when user has an ancient version of Terraform which doesn't have fmt, or if it doesn't support STDIN input.

This should also make it slightly easier to solve #164

@radeksimko radeksimko added bug Something isn't working technical-debt labels Jul 8, 2020
This was referenced Jul 8, 2020
Closed
Merged
@radeksimko radeksimko added this to the v0.4.2 milestone Jul 8, 2020
@radeksimko radeksimko mentioned this pull request Jul 9, 2020
Closed
@radeksimko radeksimko force-pushed the refactoring-root-module-context branch 3 times, most recently from 8602e34 to 4eed5f5 Compare July 9, 2020 09:40
@radeksimko radeksimko marked this pull request as ready for review July 9, 2020 09:41
@radeksimko radeksimko requested a review from a team July 9, 2020 09:41
@radeksimko radeksimko force-pushed the refactoring-root-module-context branch from 4eed5f5 to 39b9639 Compare July 9, 2020 10:11
@radeksimko radeksimko force-pushed the refactoring-root-module-context branch from 39b9639 to 3121f31 Compare July 9, 2020 11:00
This was referenced Jul 9, 2020
Merged
Closed
appilon
appilon reviewed Jul 9, 2020
View reviewed changes
Copy link
Contributor

@appilon appilon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I may be wrong as this is a big PR and I'm coming in with no knowledge, but I think there could be some minor data races on some of the booleans between goroutines. Also noticed 2 goroutines being created when I think you only needed 1?

internal/terraform/rootmodule/root_module.go Outdated Show resolved Hide resolved
internal/terraform/rootmodule/root_module.go Show resolved Hide resolved
internal/terraform/rootmodule/root_module.go Outdated Show resolved Hide resolved
internal/terraform/rootmodule/root_module.go Show resolved Hide resolved
internal/terraform/rootmodule/root_module.go Show resolved Hide resolved
internal/terraform/rootmodule/root_module.go Show resolved Hide resolved
internal/terraform/rootmodule/root_module.go Show resolved Hide resolved
internal/terraform/rootmodule/root_module.go Outdated Show resolved Hide resolved
internal/terraform/rootmodule/root_module_manager.go Outdated Show resolved Hide resolved
internal/terraform/rootmodule/root_module_manager_mock_test.go Outdated Show resolved Hide resolved
@radeksimko
Copy link
Member Author

@appilon I believe I addressed all of your valuable feedback. PTAL.

@radeksimko radeksimko requested a review from appilon July 9, 2020 16:37
appilon
appilon approved these changes Jul 9, 2020
View reviewed changes
Copy link
Contributor

@appilon appilon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@radeksimko radeksimko merged commit c41d592 into master Jul 9, 2020
@radeksimko radeksimko deleted the refactoring-root-module-context branch July 9, 2020 20:56
@radeksimko radeksimko modified the milestones: v0.4.2, v0.5.0 Jul 10, 2020
@ghost
Copy link

ghost commented Aug 8, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the context necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Aug 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@appilon appilon appilon approved these changes

Assignees
No one assigned
Labels
bug Something isn't working technical-debt
Projects
None yet
Milestone
v0.5.0
Development

Successfully merging this pull request may close these issues.

Cancel root module operations on shutdown
2 participants
@radeksimko @appilon