fix: Limit label completion items to 100 #628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we didn't correctly limit the number of candidates returned for a label completion, which in some extreme cases would mean that for a resource we would send ~700 items just for AWS provider + any more hundreds for any other providers declared in the module. This limits the items to 100 and expects the user to keep typing to filter the results.
jpogran
approved these changes
Aug 24, 2021
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we didn't correctly limit the number of candidates returned for a label completion, which in some extreme cases would mean that for a resource we would send ~700 items just for AWS provider + any more hundreds for any other providers declared in the module.
This limits the items to 100 and expects the user to keep typing to filter the results.
This PR brings in hashicorp/hcl-lang#85