Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce go-to-variable from module input name #700

Merged
merged 12 commits into from
Nov 23, 2021
Merged

Conversation

radeksimko
Copy link
Member

@radeksimko radeksimko commented Nov 8, 2021

@radeksimko radeksimko force-pushed the f-path-target branch 4 times, most recently from 8431c2d to f3392f2 Compare November 18, 2021 12:30
@radeksimko radeksimko marked this pull request as ready for review November 18, 2021 12:47
Basically just reflecting all breaking changes upstream
in hcl-lang and terraform-schema.
This prevents over-estimation of references in code lens
as a result of mistakenly reusing module references in variable files.
This is to prevent deadlock in tests, which may still occasionally
end up in a situation where two or more of the same operations
are scheduled at a time.
radeksimko and others added 2 commits November 18, 2021 15:36
Co-authored-by: Daniel Banck <dbanck@users.noreply.github.com>
Co-authored-by: Daniel Banck <dbanck@users.noreply.github.com>
@radeksimko radeksimko mentioned this pull request Nov 22, 2021
7 tasks
Copy link
Member

@dbanck dbanck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Awesome work!

@radeksimko radeksimko merged commit 5740123 into main Nov 23, 2021
@radeksimko radeksimko deleted the f-path-target branch November 23, 2021 15:18
@jamiet-msm
Copy link

NICE!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Go to variable definition (from local module arg)
3 participants