Set proper scope for machine based settings #1164
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This sets the following settings to
machine-overridable
scope. This ensures these settings will be read in the correct location whether the user is using the extension locally or in a remote context like the Remote Extensions or Codespaces.It is set to
machine-overridable
instead of justmachine
, to still allow users to have these settings set inside a Workspace file or in the Workspace folder. If we set it to justmachine
, the settings would not be modifiable in the Workspace file or in the Workspace folder scopes.For all other settings, this sets the scope to the default
window
. This removes the error messages being logged in the extension host about accessing a resource scoped setting using a non resource scoped method: