Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce deer crate at v0.0.0 #1163

Merged
merged 40 commits into from
Oct 10, 2022
Merged
Show file tree
Hide file tree
Changes from 11 commits
Commits
Show all changes
40 commits
Select commit Hold shift + click to select a range
e2eaeb0
feat: create new library
indietyp Oct 5, 2022
486a371
feat: add licenses
indietyp Oct 5, 2022
09146de
feat: populate first version of the README and changelog
indietyp Oct 5, 2022
3a9bf58
feat: skeleton lib.rs
indietyp Oct 5, 2022
9a919cc
feat: skeleton lib.rs for derive
indietyp Oct 5, 2022
f48f3eb
Update GitHub labeler to include `deer` crate
vilkinsons Oct 5, 2022
bb95c16
feat: apply suggestions from code review
indietyp Oct 5, 2022
3de3e3d
docs: augment preliminary example with `serde_json` vs `deer::json`
indietyp Oct 5, 2022
cbf9138
Update and rename LICENSE-APACHE to LICENSE-APACHE.md
vilkinsons Oct 5, 2022
fa6d6e7
Update and rename LICENSE-MIT to LICENSE-MIT.md
vilkinsons Oct 5, 2022
8eeed5d
Update README.md
vilkinsons Oct 5, 2022
87e2dc8
Set up CI for `deer` (#1164)
indietyp Oct 5, 2022
13c7137
fix: toolchain for macros
indietyp Oct 5, 2022
e7385f4
chore: prettier
indietyp Oct 5, 2022
d59bbeb
ci: exclude deer from publishing for now
indietyp Oct 5, 2022
8ac6908
fix: markdownlint
indietyp Oct 5, 2022
fba5178
fix: markdownlint (2)
indietyp Oct 5, 2022
c72e5a5
Update packages/libs/deer/README.md
indietyp Oct 6, 2022
94a590a
fix: apply suggestions from review
indietyp Oct 6, 2022
2bb0b1b
Merge branch 'bm/deer/init' of github.com:hashintel/hash into bm/deer…
indietyp Oct 6, 2022
501cb23
Update packages/libs/deer/README.md
indietyp Oct 6, 2022
644ba3b
docs: future plans
indietyp Oct 6, 2022
871d1bd
docs: future plans (II)
indietyp Oct 6, 2022
9ee9516
Merge branch 'bm/deer/init' of github.com:hashintel/hash into bm/deer…
indietyp Oct 6, 2022
a1c04ec
docs: improve wording
indietyp Oct 6, 2022
11fa2e7
Apply suggestions from code review
indietyp Oct 7, 2022
e0bfcd6
docs: apply suggestions from code review
indietyp Oct 7, 2022
5cec334
docs: apply suggestions from code review (II)
indietyp Oct 7, 2022
4ba1939
fix: remove beta toolchain from CI
indietyp Oct 7, 2022
f2a9c76
Merge branch 'bm/deer/init' of github.com:hashintel/hash into bm/deer…
indietyp Oct 7, 2022
7ca5f33
Apply suggestions from code review
indietyp Oct 7, 2022
325f94f
Merge branch 'main' into bm/deer/init
vilkinsons Oct 7, 2022
7ad467d
Update packages/libs/deer/README.md
vilkinsons Oct 7, 2022
972344b
Merge branch 'main' into bm/deer/init
vilkinsons Oct 7, 2022
689a00c
Update packages/libs/deer/README.md
TimDiekmann Oct 7, 2022
c6d278d
Apply suggestions from code review
indietyp Oct 7, 2022
14cde13
fix: apply suggestions
indietyp Oct 7, 2022
99538ec
fix: apply suggestions
indietyp Oct 7, 2022
f04f021
fix: whitespace
indietyp Oct 7, 2022
fdfde42
Merge branch 'main' into bm/deer/init
indietyp Oct 9, 2022
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .github/labeler.yml
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,12 @@ A-error-stack:
- "packages/libs/error-stack/.*"
- "packages/libs/error-stack/**/*"
- "packages/libs/error-stack/**/.*"

A-deer:
- "packages/libs/deer/*"
- "packages/libs/deer/.*"
- "packages/libs/deer/**/*"
- "packages/libs/deer/**/.*"

C-dependencies:
- "**/Cargo.lock"
Expand Down
13 changes: 13 additions & 0 deletions packages/libs/deer/.gitignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
### Rust template
# Generated by Cargo
# will have compiled files and executables
debug/
target/

# Remove Cargo.lock from gitignore if creating an executable, leave it for libraries
# More information here https://doc.rust-lang.org/cargo/guide/cargo-toml-vs-cargo-lock.html
Cargo.lock

# These are backup files generated by rustfmt
**/*.rs.bk

7 changes: 7 additions & 0 deletions packages/libs/deer/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
# Changelog
All notable changes to this project will be documented in this file.

The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
indietyp marked this conversation as resolved.
Show resolved Hide resolved

## [Unreleased]
17 changes: 17 additions & 0 deletions packages/libs/deer/Cargo.toml
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
[package]
name = "deer"
version = "0.0.0"
edition = "2021"
publish = false

# See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html

[dependencies]


indietyp marked this conversation as resolved.
Show resolved Hide resolved
[features]
default = ['std']
std = []

[workspace]
members = ['.', 'macros']
191 changes: 191 additions & 0 deletions packages/libs/deer/LICENSE-APACHE.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,191 @@
Apache License
==============

_Version 2.0, January 2004_
_&lt;<http://www.apache.org/licenses/>&gt;_

### Terms and Conditions for use, reproduction, and distribution

#### 1. Definitions

“License” shall mean the terms and conditions for use, reproduction, and
distribution as defined by Sections 1 through 9 of this document.

“Licensor” shall mean the copyright owner or entity authorized by the copyright
owner that is granting the License.

“Legal Entity” shall mean the union of the acting entity and all other entities
that control, are controlled by, or are under common control with that entity.
For the purposes of this definition, “control” means **(i)** the power, direct or
indirect, to cause the direction or management of such entity, whether by
contract or otherwise, or **(ii)** ownership of fifty percent (50%) or more of the
outstanding shares, or **(iii)** beneficial ownership of such entity.

“You” (or “Your”) shall mean an individual or Legal Entity exercising
permissions granted by this License.

“Source” form shall mean the preferred form for making modifications, including
but not limited to software source code, documentation source, and configuration
files.

“Object” form shall mean any form resulting from mechanical transformation or
translation of a Source form, including but not limited to compiled object code,
generated documentation, and conversions to other media types.

“Work” shall mean the work of authorship, whether in Source or Object form, made
available under the License, as indicated by a copyright notice that is included
in or attached to the work (an example is provided in the Appendix below).

“Derivative Works” shall mean any work, whether in Source or Object form, that
is based on (or derived from) the Work and for which the editorial revisions,
annotations, elaborations, or other modifications represent, as a whole, an
original work of authorship. For the purposes of this License, Derivative Works
shall not include works that remain separable from, or merely link (or bind by
name) to the interfaces of, the Work and Derivative Works thereof.

“Contribution” shall mean any work of authorship, including the original version
of the Work and any modifications or additions to that Work or Derivative Works
thereof, that is intentionally submitted to Licensor for inclusion in the Work
by the copyright owner or by an individual or Legal Entity authorized to submit
on behalf of the copyright owner. For the purposes of this definition,
“submitted” means any form of electronic, verbal, or written communication sent
to the Licensor or its representatives, including but not limited to
communication on electronic mailing lists, source code control systems, and
issue tracking systems that are managed by, or on behalf of, the Licensor for
the purpose of discussing and improving the Work, but excluding communication
that is conspicuously marked or otherwise designated in writing by the copyright
owner as “Not a Contribution.”

“Contributor” shall mean Licensor and any individual or Legal Entity on behalf
of whom a Contribution has been received by Licensor and subsequently
incorporated within the Work.

#### 2. Grant of Copyright License

Subject to the terms and conditions of this License, each Contributor hereby
grants to You a perpetual, worldwide, non-exclusive, no-charge, royalty-free,
irrevocable copyright license to reproduce, prepare Derivative Works of,
publicly display, publicly perform, sublicense, and distribute the Work and such
Derivative Works in Source or Object form.

#### 3. Grant of Patent License

Subject to the terms and conditions of this License, each Contributor hereby
grants to You a perpetual, worldwide, non-exclusive, no-charge, royalty-free,
irrevocable (except as stated in this section) patent license to make, have
made, use, offer to sell, sell, import, and otherwise transfer the Work, where
such license applies only to those patent claims licensable by such Contributor
that are necessarily infringed by their Contribution(s) alone or by combination
of their Contribution(s) with the Work to which such Contribution(s) was
submitted. If You institute patent litigation against any entity (including a
cross-claim or counterclaim in a lawsuit) alleging that the Work or a
Contribution incorporated within the Work constitutes direct or contributory
patent infringement, then any patent licenses granted to You under this License
for that Work shall terminate as of the date such litigation is filed.

#### 4. Redistribution

You may reproduce and distribute copies of the Work or Derivative Works thereof
in any medium, with or without modifications, and in Source or Object form,
provided that You meet the following conditions:

* **(a)** You must give any other recipients of the Work or Derivative Works a copy of
this License; and
* **(b)** You must cause any modified files to carry prominent notices stating that You
changed the files; and
* **(c)** You must retain, in the Source form of any Derivative Works that You distribute,
all copyright, patent, trademark, and attribution notices from the Source form
of the Work, excluding those notices that do not pertain to any part of the
Derivative Works; and
* **(d)** If the Work includes a “NOTICE” text file as part of its distribution, then any
Derivative Works that You distribute must include a readable copy of the
attribution notices contained within such NOTICE file, excluding those notices
that do not pertain to any part of the Derivative Works, in at least one of the
following places: within a NOTICE text file distributed as part of the
Derivative Works; within the Source form or documentation, if provided along
with the Derivative Works; or, within a display generated by the Derivative
Works, if and wherever such third-party notices normally appear. The contents of
the NOTICE file are for informational purposes only and do not modify the
License. You may add Your own attribution notices within Derivative Works that
You distribute, alongside or as an addendum to the NOTICE text from the Work,
provided that such additional attribution notices cannot be construed as
modifying the License.

You may add Your own copyright statement to Your modifications and may provide
additional or different license terms and conditions for use, reproduction, or
distribution of Your modifications, or for any such Derivative Works as a whole,
provided Your use, reproduction, and distribution of the Work otherwise complies
with the conditions stated in this License.

#### 5. Submission of Contributions

Unless You explicitly state otherwise, any Contribution intentionally submitted
for inclusion in the Work by You to the Licensor shall be under the terms and
conditions of this License, without any additional terms or conditions.
Notwithstanding the above, nothing herein shall supersede or modify the terms of
any separate license agreement you may have executed with Licensor regarding
such Contributions.

#### 6. Trademarks

This License does not grant permission to use the trade names, trademarks,
service marks, or product names of the Licensor, except as required for
reasonable and customary use in describing the origin of the Work and
reproducing the content of the NOTICE file.

#### 7. Disclaimer of Warranty

Unless required by applicable law or agreed to in writing, Licensor provides the
Work (and each Contributor provides its Contributions) on an “AS IS” BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied,
including, without limitation, any warranties or conditions of TITLE,
NON-INFRINGEMENT, MERCHANTABILITY, or FITNESS FOR A PARTICULAR PURPOSE. You are
solely responsible for determining the appropriateness of using or
redistributing the Work and assume any risks associated with Your exercise of
permissions under this License.

#### 8. Limitation of Liability

In no event and under no legal theory, whether in tort (including negligence),
contract, or otherwise, unless required by applicable law (such as deliberate
and grossly negligent acts) or agreed to in writing, shall any Contributor be
liable to You for damages, including any direct, indirect, special, incidental,
or consequential damages of any character arising as a result of this License or
out of the use or inability to use the Work (including but not limited to
damages for loss of goodwill, work stoppage, computer failure or malfunction, or
any and all other commercial damages or losses), even if such Contributor has
been advised of the possibility of such damages.

#### 9. Accepting Warranty or Additional Liability

While redistributing the Work or Derivative Works thereof, You may choose to
offer, and charge a fee for, acceptance of support, warranty, indemnity, or
other liability obligations and/or rights consistent with this License. However,
in accepting such obligations, You may act only on Your own behalf and on Your
sole responsibility, not on behalf of any other Contributor, and only if You
agree to indemnify, defend, and hold each Contributor harmless for any liability
incurred by, or claims asserted against, such Contributor by reason of your
accepting any such warranty or additional liability.

_END OF TERMS AND CONDITIONS_

### APPENDIX: Apply the Apache License to a specific file

To apply the Apache License to an individual file, attach the following notice.
The text should be enclosed in the appropriate comment syntax for the file
format.

Copyright © 2022–, HASH

Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at

http://www.apache.org/licenses/LICENSE-2.0

Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.

22 changes: 22 additions & 0 deletions packages/libs/deer/LICENSE-MIT.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
MIT License
===========

Copyright © 2022–, HASH
TimDiekmann marked this conversation as resolved.
Show resolved Hide resolved

Permission is hereby granted, free of charge, to any person obtaining a copy
of this software and associated documentation files (the "Software"), to deal
in the Software without restriction, including without limitation the rights
to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
copies of the Software, and to permit persons to whom the Software is
furnished to do so, subject to the following conditions:

The above copyright notice and this permission notice shall be included in all
copies or substantial portions of the Software.

THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
SOFTWARE.
83 changes: 83 additions & 0 deletions packages/libs/deer/README.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,83 @@
# Deer
vilkinsons marked this conversation as resolved.
Show resolved Hide resolved

`deer` is a backend agnostic deserialization framework, featuring meaningful error
messages and context (utilizing [`error-stack`](https://crates.io/crates/error-stack)) and
a fail-slow behavior by default.

## Fail-Slow

Currently, Rust deserializers are good at one thing: parsing a lot of data correct and
vilkinsons marked this conversation as resolved.
Show resolved Hide resolved
*fast*. This is often what is desired, but the need for speed sacrifices usability in
scenarios where multiple errors are of interest.
`deer` solves this exact problem, by allowing multiple errors, trying as hard as possible
vilkinsons marked this conversation as resolved.
Show resolved Hide resolved
not to fail at the first error.

## Example

A popular example for `deer` are end-user facing APIs, given the following example:
indietyp marked this conversation as resolved.
Show resolved Hide resolved

```rust
#[derive(serde::Deserialize, deer::Deserialize)]
indietyp marked this conversation as resolved.
Show resolved Hide resolved
struct Body {
i8: i8,
TimDiekmann marked this conversation as resolved.
Show resolved Hide resolved
string: String
}

fn main() {
let payload = json!({
"i8": 257,
TimDiekmann marked this conversation as resolved.
Show resolved Hide resolved
"string": null,
"extra": 1
});

// Note: Syntax is not final!
let result = deer::json::from_string::<Body>(payload);
indietyp marked this conversation as resolved.
Show resolved Hide resolved
let error = result.expect_error("should fail");
indietyp marked this conversation as resolved.
Show resolved Hide resolved
println!("{error:?}");

let result = serde_json::from_str::<Body>(payload);
indietyp marked this conversation as resolved.
Show resolved Hide resolved
let error = result.expect_error("should fail");
indietyp marked this conversation as resolved.
Show resolved Hide resolved
println!("{error:?}");
}
```

`serde` will fail immediately upon encountering that `257` is larger than what `i8`
TimDiekmann marked this conversation as resolved.
Show resolved Hide resolved
allows. This leads to frustration for the API consumer, as once they fix that issue the
next problem, that `string` cannot be null, will be returned. `serde` also does not include
path information about where the issue is located, `deer` does!

`deer` solves this problem, by returning every issue present.
This means that a single API call with the payload given will result in the
errors: `257 larger than i8::MAX`, `null is not String`, and `extra key "extra" provided`.

This in turn also means that deer can be used for custom validation while
deserializing, while still being able to return all validation issues.

<sub>
deer might provide a way in the future to describe these constraints.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On the topic of possible futures, is there a world in which we might tweak the actual amount of speed users are willing to trade-off (i.e. have multiple strategies for allowing errors, some more performant vs exhaustive than others?) I can see wanting to tweak this from time to time, depending on implementation context, and it would be nice to provide 'degrees of deer' rather than just 'deer or no deer'.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, my goal is still to be as fast as possible (there will be overhead compared to serde, but I want to benchmark before optimizing), but I could imagine a future where you can opt into some checks while excluding others.

If deer goes forward with integrated validation or coercion (in 0.2?) I want to preserve the ability to altogether opt-out of that behavior if desired.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to add this in to the README? I would be inclined to flesh out 'future plans' as much as possible here, in the initial release, to get people excited/potentially attract likeminded others.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a section on future plans in 644ba3b and 871d1bd.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure how it'll behave inside an HTML element but should we have deer code-styled like the rest of the doc?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed in 14cde13

</sub>

## Limitations

deer currently does **not** parse values itself, but relies on external parsers
like `serde_json`, this means that parsing will be fail-fast, and deer only touches
syntactically correct values.

## Contributors

`deer` was created by [Bilal Mahmoud](https://github.com/indietyp). It is being developed in conjunction with [HASH](https://hash.dev/). As an open-source project, we gratefully accept external contributions and have published a [contributing guide](https://github.com/hashintel/hash/blob/main/CONTRIBUTING.md) that outlines the process. If you have questions, please reach out to us on our [Discord server](https://hash.ai/discord).

#### License

<sup>
Licensed under either of <a href="LICENSE-APACHE">Apache License, Version
2.0</a> or <a href="LICENSE-MIT">MIT license</a> at your option.
</sup>

<br>

<sub>
Unless you explicitly state otherwise, any contribution intentionally submitted
for inclusion in this crate by you, as defined in the Apache-2.0 license, shall
be dual licensed as above, without any additional terms or conditions.
</sub>
12 changes: 12 additions & 0 deletions packages/libs/deer/macros/Cargo.toml
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
[package]
name = "deer-macro"
version = "0.0.0"
edition = "2021"
publish = false

# See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html
Alfred-Mountfield marked this conversation as resolved.
Show resolved Hide resolved

[lib]
proc-macro = true

[dependencies]
11 changes: 11 additions & 0 deletions packages/libs/deer/macros/src/lib.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
//! Intentionally left blank for now!

#![warn(
missing_docs,
unreachable_pub,
clippy::pedantic,
clippy::nursery,
clippy::undocumented_unsafe_blocks
)]
#![allow(clippy::redundant_pub_crate)]
#![allow(clippy::module_name_repetitions)]
4 changes: 4 additions & 0 deletions packages/libs/deer/rust-toolchain.toml
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
[toolchain]
# Please also update the badges in `README.md`, `src/lib.rs`, and `macros/`
indietyp marked this conversation as resolved.
Show resolved Hide resolved
channel = "nightly-2022-09-27"
TimDiekmann marked this conversation as resolved.
Show resolved Hide resolved
components = ['rust-src', 'clippy', 'rustfmt']
TimDiekmann marked this conversation as resolved.
Show resolved Hide resolved
Loading