Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce
deer
crate at v0.0.0 #1163Introduce
deer
crate at v0.0.0 #1163Changes from 11 commits
e2eaeb0
486a371
09146de
3a9bf58
9a919cc
f48f3eb
bb95c16
3de3e3d
cbf9138
fa6d6e7
8eeed5d
87e2dc8
13c7137
e7385f4
d59bbeb
8ac6908
fba5178
c72e5a5
94a590a
2bb0b1b
501cb23
644ba3b
871d1bd
9ee9516
a1c04ec
11fa2e7
e0bfcd6
5cec334
4ba1939
f2a9c76
7ca5f33
325f94f
7ad467d
972344b
689a00c
c6d278d
14cde13
99538ec
f04f021
fdfde42
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On the topic of possible futures, is there a world in which we might tweak the actual amount of speed users are willing to trade-off (i.e. have multiple strategies for allowing errors, some more performant vs exhaustive than others?) I can see wanting to tweak this from time to time, depending on implementation context, and it would be nice to provide 'degrees of deer' rather than just 'deer or no deer'.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, my goal is still to be as fast as possible (there will be overhead compared to serde, but I want to benchmark before optimizing), but I could imagine a future where you can opt into some checks while excluding others.
If deer goes forward with integrated validation or coercion (in 0.2?) I want to preserve the ability to altogether opt-out of that behavior if desired.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you want to add this in to the README? I would be inclined to flesh out 'future plans' as much as possible here, in the initial release, to get people excited/potentially attract likeminded others.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a section on future plans in 644ba3b and 871d1bd.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure how it'll behave inside an HTML element but should we have
deer
code-styled like the rest of the doc?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed in 14cde13