-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dual-license error-stack
and misc drive-by updates
#1172
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pre-emptively remove reference to `sites` directory ahead of improvements to monorepo structure (introduction of top-level `apps` directory, etc.)
Consistency with BP READMEs, and new `deer` README
github-actions
bot
added
area/libs > error-stack
Affects the `error-stack` crate (library)
area/infra
Relates to version control, CI, CD or IaC (area)
labels
Oct 6, 2022
vilkinsons
commented
Oct 6, 2022
vilkinsons
commented
Oct 6, 2022
Add contributor and license sections to `error-stack` README
Testing to see if this breaks the ordering...
indietyp
reviewed
Oct 7, 2022
sites/hashdev/src/_pages/blog/5_build-blocks-in-any-language.mdx
Outdated
Show resolved
Hide resolved
vilkinsons
commented
Oct 7, 2022
sites/hashdev/src/_pages/blog/5_build-blocks-in-any-language.mdx
Outdated
Show resolved
Hide resolved
Co-authored-by: Tim Diekmann <21277928+TimDiekmann@users.noreply.github.com>
Co-authored-by: Tim Diekmann <21277928+TimDiekmann@users.noreply.github.com>
Co-authored-by: Tim Diekmann <21277928+TimDiekmann@users.noreply.github.com>
TimDiekmann
approved these changes
Oct 7, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated the README.md
s in sites/hashdev/public/blog
to point to the correct folders in 674e274
Changes are looking good, but I noticed, that a readme for the 5. and 9. blog post are missing.
TimDiekmann
previously requested changes
Oct 7, 2022
TimDiekmann
approved these changes
Oct 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/infra
Relates to version control, CI, CD or IaC (area)
area/libs > error-stack
Affects the `error-stack` crate (library)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🌟 What is the purpose of this PR?
This PR combines multiple miscellaneous changes.
CONTRIBUTING
file.error-stack
Rust crate (introducing Apache 2.0 as an option, complementing the existing MIT license).error-stack
README and adds additional information.deer
crate GitHub Issue bug report form ahead of Introducedeer
crate at v0.0.0 #1163 merging