Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HLint doesn't report "Unused LANGUAGE pragma" #2042

Closed
georgefst opened this issue Jul 27, 2021 · 3 comments · Fixed by #2366
Closed

HLint doesn't report "Unused LANGUAGE pragma" #2042

georgefst opened this issue Jul 27, 2021 · 3 comments · Fixed by #2366
Labels
component: hls-hlint-plugin type: bug Something isn't right: doesn't work as intended, documentation is missing/outdated, etc..

Comments

@georgefst
Copy link
Collaborator

File contains just:

{-# LANGUAGE BangPatterns #-}

HLS reports no warnings. HLint 3.2.7 on the command line says:

haskell/Main.hs:1:1-29: Warning: Unused LANGUAGE pragma
Found:
  {-# LANGUAGE BangPatterns #-}
Perhaps you should remove it.

Odd. Is HLS intentionally disabling these hints for some reason?
@jneira jneira added component: hls-hlint-plugin type: bug Something isn't right: doesn't work as intended, documentation is missing/outdated, etc.. labels Jul 27, 2021
@jneira
Copy link
Member

jneira commented Jul 27, 2021

Hmm i would swear i've seen warning about unused pragmas at some point, will try to reproduce

@georgefst
Copy link
Collaborator Author

Thanks. Let me know if you can't and I'll try to narrow it down.

@jneira
Copy link
Member

jneira commented Jul 29, 2021

Can reproduce at first, not sure when it has started to fail, maybe since the pr which added support for ghc-9
We need a regression test here and investigate

@georgefst georgefst mentioned this issue Sep 18, 2021
Closed
jneira added a commit to jneira/haskell-language-server that referenced this issue Nov 3, 2021
@jneira
Add test for haskell#2042
e703df4
@jneira jneira mentioned this issue Nov 6, 2021
Merged
mergify bot pushed a commit that referenced this issue Nov 10, 2021
@jneira
[skip circleci] Rename hlint test data files and add regression tests (…
7011d5e 
…#2321)

* Rename test data files

* Add regression tests

* Add regression test for #1279

* Use timeout

* Correct waitForProgressDone in ghcide

* Remove unnecessary waitForDiagnostics

* Mark test broken for hlint on ghclib

* Add test over unused extensions

* Add test for #2042

* Add data for #2280

* Use waitForAllProgressDone

* Add test for #2280

* correct module name

* Add reproduction for #2290

* Correct test case

* Comment about knownBrokenForHlint*

* Correction
@jneira jneira mentioned this issue Nov 18, 2021
Merged
jneira added a commit to jneira/haskell-language-server that referenced this issue Nov 18, 2021
@jneira
Remove unknown broken for haskell#638, haskell#2042 and haskell#2280
3bd37ba
jneira added a commit to jneira/haskell-language-server that referenced this issue Nov 18, 2021
@jneira
Remove unknown broken for haskell#638, haskell#2042 and haskell#2280
90ed2f5
@mergify mergify bot closed this as completed in #2366 Nov 19, 2021
mergify bot pushed a commit that referenced this issue Nov 19, 2021
@jneira
Fix several hlint issues related with the use of parsed module withou…
1892c8f 
…t comments (#2366)

* Replace * with -

* Use parsed module with comments

* Correct issue id

* Remove unknown broken for #638, #2042 and #2280
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: hls-hlint-plugin type: bug Something isn't right: doesn't work as intended, documentation is missing/outdated, etc..
Projects
None yet
Milestone
No milestone
2 participants
@jneira @georgefst