use chrome storage api & code cleanup #10
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
November 28, 2017 10:40
|
Nice! Sorry for the delay. I'll try to merge this ASAP |
js/options.js
Outdated
| // Saves options to localStorage. | ||
|
|
||
| const DEFAULT_MYOPENHAB_URL = "https://home.myopenhab.org"; | ||
| const DEFAULT_PATH = "basicui/app"; |
There was a problem hiding this comment.
It should be "/basicui/app"
|
@lleifermann About the issue #7 : I've tried to replicate again, with chrome-stable (Version 63.0.3239.132 (Official Build) (64-bit)) both on Windows 10 and Ubuntu 10.17 I got the same problem. Back button did not work. |
|
@lucianopeixoto I just corrected the basicui path. When i tested it at the time, only chromium was affected, this seems not to be the case anymore. I'am going to look into this further this week. |
|
Any progress on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
i recently ported this Chrome extension to Firefox. In the process i made some changes to the code and wanted to introduce them here too. You can find it here:
https://github.com/lleifermann/openhab-firefox
The PR mainly covers the following things:
If you guys want, its now very easy to enable chrome sync for all saved values. This isnt enabled yet because i felt we should first discuss it here.
I also removed the unnecessary .vs folder that got merged in and tried to create a somewhat logical folder structure, to maintain the code a bit better.
I also tried to reproduce this issue: #7
I was only able to reproduce the bug in chromium, not in chrome-stable. The back button works as expected there.
My guess is that the content security policy in chromium disables the XHR requests in the loaded iframe javascript, even if you allow certain domains. If you monitor the requests made from the addon in the debugger, you can clearly see that the back button does not even trigger a request at all.
This is very weird behavior, we should investigate this issue further. Maybe its even a chromium related bug.
Before approving or merging this, please go ahead and test the changes in your chrome/chromium instance.