add new permissions from android API 31 #1642
Conversation
|
We've been discussing this in #1621. My preference would be to move this to a separate function in addition to adding the require permissions for newer Android versions. |
done |
| Permission.ACCESS_COARSE_LOCATION, | ||
| Permission.ACCESS_BACKGROUND_LOCATION, | ||
| ] | ||
| VERSION = autoclass('android.os.Build$VERSION') |
There was a problem hiding this comment.
To be consistent with other constants in the android backend, I would expect this to be defined in the defs module.
| @@ -307,6 +307,15 @@ def set_scanning_filter(self, **kwargs) -> None: | |||
| """ | |||
| raise NotImplementedError() | |||
|
|
|||
| @abc.abstractmethod | |||
| async def request_permissions(self, **kwargs) -> None: | |||
There was a problem hiding this comment.
Since this only applies to Android, I don't think we should make this a common function to all platforms.
Also, it is not specifically related to the BleakScanner, so should not be a method on that object.
Making it a standalone function in p2andoid.utils seems like the logical place to put it.
| @@ -41,7 +41,9 @@ async def example(self): | |||
| while self.running: | |||
| try: | |||
| self.line("scanning") | |||
| scanned_devices = await bleak.BleakScanner.discover(1) | |||
| scanner = bleak.BleakScanner() | |||
| await scanner.request_permissions() | |||
There was a problem hiding this comment.
This should only be called once at the start of the program. Also, it needs to be guarded with an if or in a try/except so that the program can run on platforms other than android.
| scanned_devices = await bleak.BleakScanner.discover(1) | ||
| scanner = bleak.BleakScanner() | ||
| await scanner.request_permissions() | ||
| scanned_devices = scanner.discover(1) |
There was a problem hiding this comment.
discover() is not an instance method, so we should not be creating a BleakScanner() instance.
| BleakError("User denied access to " + str(permissions)) | ||
| ) | ||
| ) | ||
| if not kwargs.get("permissions"): |
There was a problem hiding this comment.
Instead of kwargs, I would just make a named arg that defaults the default permissions.
|
Also, we will need a changelog entry explaining that this is a breaking change. |
Pull Request Guidelines for Bleak
Before you submit a pull request, check that it meets these guidelines:
CHANGELOG.rst, describing your changes as is specified by theguidelines in that document.
different problems and you are committing them in the same PR. In that case,
consider making several PRs instead.
AUTHORS.rstfile!