Current WIP for rppd-to-lobid transformation (RPB-102) #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: maipet <maipet@users.noreply.github.com>
Co-authored-by: maipet <maipet@users.noreply.github.com>
- Prefer GND IDs and namespace for `id` field - Add `type` field with hard-coded values - Set filenames and indexing settings
Need test case
We are using the links of the GND explorer here, since we do not have the pictures yet.
Using 1) `cat conf/RPB-Export_HBZ_Bio.txt | grep -a '#1wz' | tail -n 1 >> conf/RPB-Export_HBZ_Bio_Test.txt` 2) `sbt "runMain rpb.ETL conf/rppd-to-strapi.flux"` 3) `sbt "runMain rpb.ETL conf/rppd-test-to-lobid.flux"`
TobiasNx
reviewed
Nov 2, 2023
conf/rppd-to-lobid.fix
Outdated
| "variantName[]", | ||
| "periodOfActivity[]", | ||
| "placeOfActivity[]", | ||
| "gndSubjectCategory[]" |
There was a problem hiding this comment.
Gut wäre es hier die Werte alphabetisch sortieren.
TobiasNx
reviewed
Nov 2, 2023
TobiasNx
reviewed
Nov 2, 2023
|
Are the *.txt files for debugging/development? Are they intentionally checked in?
|
|
Yes, they are helper files to provide the pathes for quickly checking and changing transformations. |
|
Alright, then I'd say we leave them where they are for now. You mentioned we should clean up the conf folder anyway, so maybe we do that in a separate PR, with something like subfolders for each data source (rpb, sw, rppd etc.) |
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://jira.hbz-nrw.de/browse/RPB-102