Skip to content
This repository has been archived by the owner on Aug 3, 2020. It is now read-only.

Drop setIf and includeSubdomains options #24

Closed
wants to merge 3 commits into from
Closed

Drop setIf and includeSubdomains options #24

wants to merge 3 commits into from

Conversation

gzog
Copy link

@gzog gzog commented May 29, 2019

@EvanHahn
Copy link
Member

EvanHahn commented Jun 4, 2019

Thanks! I'll take a closer look at this soon, but it'll only be released in the next major version.

@EvanHahn
Copy link
Member

This looks good, but #25 is going to convert the project to TypeScript, which is going to cause a bunch of merge conflicts. I'll plan to clean those up, but that may delay the merge of this PR.

@EvanHahn
Copy link
Member

EvanHahn commented Sep 1, 2019

I did this manually in 2cb4cc5, which will be deployed in hsts@3 and helmet@4. See #29 for progress there.

@EvanHahn EvanHahn closed this Sep 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Strict-Transport-Security: Remove setIf Strict-Transport-Security: Remove includeSubdomains (lowercase d)
2 participants
@gzog @EvanHahn