Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

continued_indentation: Make the E128 check similar to pycodestyle #585

Merged
merged 2 commits into from
Feb 25, 2021
Merged

continued_indentation: Make the E128 check similar to pycodestyle #585

merged 2 commits into from
Feb 25, 2021
+4 −3

Commits on Feb 24, 2021

  1. continued_indentation: Make the E128 check similar to pycodestyle 

    Maybe a simple botch in the following commit:

```
commit 0f06de1
Author: Steven Myint <git@stevenmyint.com>
Date:   Sat Sep 7 12:52:08 2013 -0700

    Get indentation information directly from pep8

    This greatly speeds up the "E12" indentation fixes.
```

A small test case:
```
a = {x: f(x,
     x)
     for x in xs}
```
* autopep8 without this commit complains E128.
* pycodestyle 2.6.0 doesn't complain.
* autopep8 with this commit doesn't complain.
    @yamt
    yamt committed Feb 24, 2021
    Configuration menu
    Copy the full SHA
    4062dc6 View commit details
    Browse the repository at this point in the history

  2. Update test_autopep8.py after continued_indentation fix 

    While I'm not a pep8-laywer, pycodestyle seems to allow either styles.
    @yamt
    yamt committed Feb 24, 2021
    Configuration menu
    Copy the full SHA
    67f1956 View commit details
    Browse the repository at this point in the history