Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to ALLOWED_EVENTS #7804

Merged
merged 3 commits into from
May 10, 2024
Merged

Switch to ALLOWED_EVENTS #7804

merged 3 commits into from
May 10, 2024

Conversation

timolegros
Copy link
Collaborator

Link to Issue

Closes: #7797

Description of Changes

  • Switches DISALLOWED_EVENTS to ALLOWED_EVENTS to improve devX

Test Plan

  • Remove DISALLOWED_EVENTS and ALLOWED_EVENTS from env var
  • Start the Commonwealth server
  • Create a thread + comment (should complete successfully)

Deployment Plan

  1. Set ALLOWED_EVENTS=ChainEventCreated,SnapshotProposalCreated in all Heroku environments

Other Considerations

@timolegros timolegros marked this pull request as ready for review May 10, 2024 16:26
@timolegros timolegros merged commit 3fcaaf9 into master May 10, 2024
6 of 8 checks passed
@timolegros timolegros deleted the tim/allowed-events branch May 10, 2024 18:09
jnaviask pushed a commit that referenced this pull request May 10, 2024
@timolegros @jnaviask
Switch to ALLOWED_EVENTS (#7804)
d2bf257 
* ALLOWED_EVENTS

* attempt CI fix #1

* add ThreadUpvoted to allowed events
@timolegros timolegros mentioned this pull request May 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kurtisassad kurtisassad kurtisassad approved these changes

@Rotorsoft Rotorsoft Rotorsoft approved these changes

@rbennettcw rbennettcw Awaiting requested review from rbennettcw

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clarify event emission allow list
3 participants
@timolegros @kurtisassad @Rotorsoft