Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Migrations necessary for Edgeware Node Upgrade #5

Closed

Conversation

apopiak
Copy link
Collaborator

@apopiak apopiak commented Jun 4, 2020

PR for creating the migrations necessary for the runtime upgrade from v1.0.1redo to time-travel.

Included Migrations

related to hicommonwealth/edgeware-node#164

@apopiak apopiak changed the title (Re-) Add Migrations to Substrate necessary for Edgeware Node Upgrade [WIP] Migrations necessary for Edgeware Node Upgrade Jun 4, 2020
@drewstone
Copy link
Collaborator

I think this is missing at least 1 thing, namely weights to this function:

error: `on_runtime_upgrade` must return Weight, signature has changed.
   --> /Users/drewstone/.cargo/git/checkouts/substrate-174177a5e735c2b8/a89dfc5/frame/balances/src/lib.rs:405:1
    |
405 | / decl_module! {
406 | |     pub struct Module<T: Trait<I>, I: Instance = DefaultInstance> for enum Call where origin: T::Origin {
407 | |         type Error = Error<T, I>;
408 | |
...   |
550 | |     }
551 | | }
    | |_^
    |
    = note: this error originates in a macro (in Nightly builds, run with -Z macro-backtrace for more info)

@apopiak apopiak closed this Jun 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants