Close opened image files

CHANGELOG.md

@@ -4,6 +4,10 @@
 
  * Ruby 2.7.0 support
 
+### Bug Fixes
+
+ * Close opened image file #31
+
 ## 3.1.0
 
 ### Minor Enhancements

lib/prawn/emoji/drawer.rb

@@ -50,7 +50,16 @@ def draw_emoji(text, text_options:, base_text:)
         x = image.adjust_x(base_x + @document.width_of(base_text + text.left, text_options))
         y = image.adjust_y(base_y)
 
-        @document.image image.path, at: [x, y], width: image.width
+        # Prawn 2.2 does not close the image file when Pathname is passed to Document#image method.
+        #
+        # FIXME: This issue has been fixed by https://github.com/prawnpdf/prawn/pull/1090 but not released.
+        # Fix as follows after the PR released.
+        #
+        #   @document.image(image_file.path, at: [x, y], width: image.width)
+        #
+        File.open(image.path, 'r') do |image_file|
+          @document.image(image_file, at: [x, y], width: image.width)
+        end
       end
     end
   end

test/units/prawn/emoji/drawer_test.rb

@@ -47,7 +47,7 @@
           sushi_image.adjust_x(x),
           sushi_image.adjust_y(200)
         ]
-        mock(document).image(sushi_image.path, at: position, width: sushi_image.width).once
+        mock(document).image(is_a(File), at: position, width: sushi_image.width).once
       end
       subject
     end
@@ -117,4 +117,33 @@
       it { _(subject).must_equal [sub_char * 2, japanese, sub_char * 2, japanese, sub_char * 2].join }
     end
   end
+
+  describe 'Closing opened image files' do
+    let(:text) { '🍣' }
+    let(:text_options) { { at: [100, 200], font_size: 12 } }
+
+    it do
+      opened_files = { before: count_opened_files, after: nil }
+
+      disable_gc {
+        subject
+        opened_files[:after] = count_opened_files
+      }
+
+      _(opened_files[:after]).must_equal opened_files[:before]
+    end
+
+    def count_opened_files
+      ObjectSpace.each_object(File).reject(&:closed?).count
+    end
+
+    def disable_gc
+      was_disabled = GC.disable
+      begin
+        yield
+      ensure
+        GC.enable unless was_disabled
+      end
+    end
+  end
 end