Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enh(csharp) add Contextual keywords file, args, dynamic, record, required and scoped #4087

Merged
merged 6 commits into from
Aug 10, 2024

Conversation

alvinsjoy
Copy link
Contributor

@alvinsjoy alvinsjoy commented Aug 1, 2024

Resolves #4050

Changes

Add new contextual keywords file, args, dynamic, record, required and scoped.

Checklist

  • Added markup tests, or they don't apply here because no major changes
  • Updated the changelog at CHANGES.md

Copy link

github-actions bot commented Aug 1, 2024

Build Size Report

Changes to minified artifacts in /build, after gzip compression.

4 files changed

Total change +41 B

View Changes
file base pr diff
es/core.min.js 8.2 KB 8.2 KB +1 B
es/highlight.min.js 8.2 KB 8.2 KB +1 B
es/languages/csharp.min.js 1.68 KB 1.7 KB +19 B
languages/csharp.min.js 1.69 KB 1.71 KB +20 B

Copy link

github-actions bot commented Aug 1, 2024

Build Size Report

Changes to minified artifacts in /build, after gzip compression.

5 files changed

Total change +42 B

View Changes
file base pr diff
es/core.min.js 8.2 KB 8.2 KB +1 B
es/highlight.min.js 8.2 KB 8.2 KB +1 B
es/languages/csharp.min.js 1.68 KB 1.7 KB +19 B
highlight.min.js 8.23 KB 8.23 KB +1 B
languages/csharp.min.js 1.69 KB 1.71 KB +20 B

src/languages/csharp.js Outdated Show resolved Hide resolved
Copy link

github-actions bot commented Aug 2, 2024

Build Size Report

Changes to minified artifacts in /build, after gzip compression.

5 files changed

Total change +42 B

View Changes
file base pr diff
es/core.min.js 8.2 KB 8.2 KB +3 B
es/highlight.min.js 8.2 KB 8.2 KB +3 B
es/languages/csharp.min.js 1.68 KB 1.7 KB +16 B
highlight.min.js 8.23 KB 8.23 KB +2 B
languages/csharp.min.js 1.69 KB 1.71 KB +18 B

@joshgoebel
Copy link
Member

Ok removed. But wouldn't we also want to add it to the list of data types?

@alvinsjoy
Copy link
Contributor Author

I've removed nint from the contextual keywords. When you mentioned a "list of types," were you referring to the built-in keywords? If so nint is already present there. If you were referring to a different list, could you specify which one?

Hi, as I mentioned in the pull request review reply, could you please clarify which list you are referring to as "data types"?

@joshgoebel
Copy link
Member

Could be named better, but I'm referring to BUILT_IN_KEYWORDS. If you wanted to rename that to TYPES and scope them all as type that'd be fine also.

@alvinsjoy
Copy link
Contributor Author

nint was already present in BUILT_IN_KEYWORDS, so should it be kept as it is for now? Are there any other keywords that has to be moved?

Copy link

github-actions bot commented Aug 4, 2024

Build Size Report

Changes to minified artifacts in /build, after gzip compression.

5 files changed

Total change +31 B

View Changes
file base pr diff
es/core.min.js 8.2 KB 8.2 KB -1 B
es/highlight.min.js 8.2 KB 8.2 KB -1 B
es/languages/csharp.min.js 1.68 KB 1.7 KB +16 B
highlight.min.js 8.23 KB 8.23 KB -1 B
languages/csharp.min.js 1.69 KB 1.71 KB +18 B

CHANGES.md Outdated Show resolved Hide resolved
Copy link

Build Size Report

Changes to minified artifacts in /build, after gzip compression.

5 files changed

Total change +31 B

View Changes
file base pr diff
es/core.min.js 8.2 KB 8.2 KB -1 B
es/highlight.min.js 8.2 KB 8.2 KB -1 B
es/languages/csharp.min.js 1.68 KB 1.7 KB +16 B
highlight.min.js 8.23 KB 8.23 KB -1 B
languages/csharp.min.js 1.69 KB 1.71 KB +18 B

@joshgoebel
Copy link
Member

THanks so much!

@joshgoebel joshgoebel merged commit 1711895 into highlightjs:main Aug 10, 2024
19 checks passed
@alvinsjoy alvinsjoy changed the title enh(csharp) add Contextual keywords file, args, dynamic, nint, record, required and scoped enh(csharp) add Contextual keywords file, args, dynamic, record, required and scoped Aug 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(C#) file keyword/accessibility modifier isn't highlighted
2 participants