Skip to content
This repository has been archived by the owner on Jun 8, 2022. It is now read-only.

fsnotify moving notice #84

Merged
merged 3 commits into from
Feb 9, 2014
Merged

fsnotify moving notice #84

merged 3 commits into from
Feb 9, 2014

Conversation

nathany
Copy link
Contributor

@nathany nathany commented Jan 30, 2014

Go 1.3 will include os/fsnotify in the standard library with a new API.

  • Import code.google.com/p/go.exp/fsnotify (GoDoc) for the latest API under development.
  • Continue importing github.com/howeyc/fsnotify (GoDoc) for the stable API.
  • Report Issues to go.exp/fsnotify after testing against code.google.com/p/go.exp/fsnotify

@nathany
Copy link
Contributor Author

nathany commented Jan 30, 2014

You may want to wait until https://codereview.appspot.com/58500043/ is merged before merging this.

This was referenced Jan 31, 2014
@nathany
Copy link
Contributor Author

nathany commented Feb 1, 2014

@kardianos @eaburns @mirtchovski @parkghost @romanoff @kylelemons

GoDoc indicates that you have a package that imports code.google.com/p/go.exp/fsnotify.

Please be aware that go.exp is experimental and the API will be changing over the next few weeks. If you don't want to update your package in lock-step, consider importing github.com/howeyc/fsnotify. Thanks!

@eaburns
Copy link

eaburns commented Feb 2, 2014

Thanks for the heads up.

On Fri Jan 31 2014 at 11:13:39 PM, Nathan Youngman notifications@github.com
wrote:

@kardianos https://github.com/kardianos @eaburnshttps://github.com/eaburns
@mirtchovski https://github.com/mirtchovski @parkghosthttps://github.com/parkghost
@romanoff https://github.com/romanoff @kylelemonshttps://github.com/kylelemons

GoDoc indicateshttp://godoc.org/code.google.com/p/go.exp/fsnotify?importersthat you have a package that imports
code.google.com/p/go.exp/fsnotify.

Please be aware that go.exp is experimental and the API will be
changing over the next few weeks. If you don't want to update your package
in lock-step, consider importing github.com/howeyc/fsnotify. Thanks!


Reply to this email directly or view it on GitHubhttps://github.com//pull/84#issuecomment-33863104
.

@nathany
Copy link
Contributor Author

nathany commented Feb 2, 2014

I'll drop a note here once https://codereview.appspot.com/58500043/ is merged. Until then I don't recommend importing go.exp/fsnotify - unless you want to leap back in time.

@nathany
Copy link
Contributor Author

nathany commented Feb 6, 2014

@howeyc Should we try to apply bug fixes to both repositories while only changing the API at go.exp/fsnotify?

@eaburns
Copy link

eaburns commented Feb 6, 2014

I'm not sure to whom this question is directed, but since I'm CCed, I'll
answer.

If it's not hard to fix the bugs in both places then it's nice to have
fewer bugs out in the wild. However, I haven't seen any issues with my
Watch program using the howeyec repository, so if it's going to be a big
time sink to fix both, then I don't mind waiting for go.exp to get the
fixes.

On Thu Feb 06 2014 at 9:44:21 AM, Nathan Youngman notifications@github.com
wrote:

@howeyc https://github.com/howeyc Should we try to apply bug fixes to
both repositories while only changing the API at go.exp/fsnotify?


Reply to this email directly or view it on GitHubhttps://github.com//pull/84#issuecomment-34328763
.

@nathany
Copy link
Contributor Author

nathany commented Feb 7, 2014

CL 58500043 has been merged. https://codereview.appspot.com/58500043/
So now both repositories match.

@eaburns I agree. Maybe we can fix a few issues before jumping on the API changes.

howeyc added a commit that referenced this pull request Feb 9, 2014
@howeyc howeyc merged commit b4af298 into howeyc:master Feb 9, 2014
@nathany nathany deleted the moving branch May 24, 2014 02:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants