Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow 'gs' to Specify Gather-Scatter Kernel #218

Closed
wants to merge 1 commit into from

Conversation

radelja
Copy link
Contributor

@radelja radelja commented Sep 28, 2024

Overview

This PR updates the command-line parsing to allow both 'gs' and 'sg' to specify the gather-scatter kernel. The argument parsing for JSON files already supports both of these options.

✨ Change Description/Rationale

👀 Reviewer Checklist

  • All GitHub actions and runners have passed if applicable
  • Commits are clean and relevant

✅ PR Checklist

  • Remove or update the template boilerplate text
  • Commits are relevant and combined where appropriate
  • Rebase off spatter-devel
  • Reviewers Requested
  • Projects associated
  • Commits mention issue and/or PR numbers at the bottom of the message
  • Relevant issues are linked into the PR
  • TODOs are completed
  • Reviewer checklist is updated

🚀 TODOs

  • No additional TODOs for this PR

📌 Future Work

  • No additional future work

Copy link
Contributor

@jyoung3131 jyoung3131 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, although I wonder if this is confusing for us to allow this? The alternative seems to be to fix the JSON so it only takes one option. What do you think @plavin?

@radelja radelja closed this Oct 11, 2024
@radelja radelja deleted the gs-option-fix branch October 11, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants