Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc-3 #225

Merged
merged 15 commits into from
Dec 16, 2023
Merged

misc-3 #225

merged 15 commits into from
Dec 16, 2023

Conversation

LinqLover
Copy link
Collaborator

@codeZeilen Very brief review would be great, in particular for the aesthetic change on the title page (351f990) :)

Those are intended as technical keys and not for human reading. Don't challenge PDF viewers out there with handling quotes and spaces in such keys.

Note that there are many further occurences of this pattern in several code environments. I didn't bother for them now.
Some readers (e.g., PDF.js) depend on this but otherwise treat the URL as relative.
@LinqLover LinqLover self-assigned this Nov 25, 2023
@codeZeilen
Copy link
Member

@LinqLover Do we have a tag for the print release commit (can't see them in the app apparently)? If yes, I am fine with merging it into master and adding it to the CI.

Only thing that I find important: It should be clear that the in-image format is an extension, not an elementary part of the project. I would like to avoid a situation in the future in which an improvement to the book does not happen bc it would conflict with the extractor in some way.

@LinqLover
Copy link
Collaborator Author

@codeZeilen Ouch, sorry for the late reply.

Yes, there's a 6.0 release: https://github.com/hpi-swa-lab/SqueakByExample-english/releases/tag/6.0

Only thing that I find important: It should be clear that the in-image format is an extension, not an elementary part of the project. I would like to avoid a situation in the future in which an improvement to the book does not happen bc it would conflict with the extractor in some way.

+1. Will document that.

@LinqLover LinqLover merged commit b3694e3 into master Dec 16, 2023
12 checks passed
@LinqLover LinqLover deleted the misc-3 branch December 16, 2023 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants