Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add v1 api #194

Merged
merged 5 commits into from
Mar 6, 2024
Merged

feat: add v1 api #194

merged 5 commits into from
Mar 6, 2024

Conversation

Lash-L
Copy link
Collaborator

@Lash-L Lash-L commented Mar 1, 2024

This is the next big push towards getting support for A01 devices added in. It may change a bit from here but this is the foundation. Essentially, RoborockClient, RoborockLocalClient, and RoborockMqttClient should hold generic actions that should be true for all Roborock devices. Local + Mqtt should contain their respective generic things, then V1 and A01 should hold any specific implementation that is unique to that protocol.

@humbertogontijo
Copy link
Owner

I loved the way you made this PR looks simpler than it actually is
I think it looks good, but let me just digest these changes a bit
One thing that I can see is the naming with v1 in the middle. I think it should be at the end (file name and class name)

@Lash-L
Copy link
Collaborator Author

Lash-L commented Mar 1, 2024

I loved the way you made this PR looks simpler than it actually is I think it looks good, but let me just digest these changes a bit One thing that I can see is the naming with v1 in the middle. I think it should be at the end (file name and class name)

I tried to keep it as basic as possible, but it is a large change so that was a bit tricky. I also didn't want to complicate things more by adding A01 in yet.

I've gone ahead and changed the location of the V1 in the naming

Copy link
Owner

@humbertogontijo humbertogontijo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets move on with this

@Lash-L Lash-L merged commit 9fb124e into main Mar 6, 2024
7 checks passed
@Lash-L Lash-L deleted the va01 branch March 6, 2024 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants