-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reorganize and format code #2
Comments
Thank you for the feedback. I'm planning to keep chipping away at it, to
get it be more automated. Basically the goal is to make it as simple as a
pip install, and then running a setup to set the needed variables. I'll
probably start a new branch and begin working on that in the next couple of
days. For now, I really just wanted to get the first round of code out
there, so people could use it if they like. Knowing what I learned through
this process, I think there could be some really compelling use cases way
beyond what I wrote it for.
I'll definitely refactor and reorganize it as I go. Most of my code to
date has been closed source. So I cant say that I've had many people
actually read it before :)
…On Fri, Dec 8, 2023 at 2:06 PM Alejandro González Momblán < ***@***.***> wrote:
Hi there,
I love the idea of the project and it is very interesting and definitely
helps you on your daily shopping (and it surely can be expanded to other
markets as well).
I've taken a look at the code and it can be improved in terms of
readability and maintainability. I highly recommend creating new modules
and adding docstrings everywhere. That will help you in further development
and also will make other people understand the code easily. Finally, you
could encapsulate all the project in a package so it can be distributed and
managed effortless.
Anyway, the project looks nice the way it is right now. Congratulations
for the result and the job done!
—
Reply to this email directly, view it on GitHub
<#2>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ASZQAMBPQH4J3PCCJNJPEQLYIOFN3AVCNFSM6AAAAABANH6HG6VHI2DSMVQWIX3LMV43ASLTON2WKOZSGAZTGMZWG43DQOA>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
Wanted to post an update. I believe I can work through making it so one time passcodes are viable. I was going to use sqlite3, but I may press ahead and just use postgres. If I can do this, it would mean this tool could bolt in to any situation. |
That's really nice, I hope you can make that happen! |
Hi there,
I love the idea of the project and it is very interesting and definitely helps you on your daily shopping (and it surely can be expanded to other markets as well).
I've taken a look at the code and it can be improved in terms of readability and maintainability. I highly recommend creating new modules and adding docstrings everywhere. That will help you in further development and also will make other people understand the code easily. Finally, you could encapsulate all the project in a package so it can be distributed and managed effortless.
Anyway, the project looks nice the way it is right now. Congratulations for the result and the job done!
The text was updated successfully, but these errors were encountered: