Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize and format code #2

Open
YisusChrist opened this issue Dec 8, 2023 · 3 comments
Open

Reorganize and format code #2

YisusChrist opened this issue Dec 8, 2023 · 3 comments

Comments

@YisusChrist
Copy link

Hi there,

I love the idea of the project and it is very interesting and definitely helps you on your daily shopping (and it surely can be expanded to other markets as well).

I've taken a look at the code and it can be improved in terms of readability and maintainability. I highly recommend creating new modules and adding docstrings everywhere. That will help you in further development and also will make other people understand the code easily. Finally, you could encapsulate all the project in a package so it can be distributed and managed effortless.

Anyway, the project looks nice the way it is right now. Congratulations for the result and the job done!

@huths0lo
Copy link
Owner

huths0lo commented Dec 8, 2023 via email

@huths0lo
Copy link
Owner

huths0lo commented Dec 9, 2023

Wanted to post an update. I believe I can work through making it so one time passcodes are viable. I was going to use sqlite3, but I may press ahead and just use postgres. If I can do this, it would mean this tool could bolt in to any situation.

@YisusChrist
Copy link
Author

Wanted to post an update. I believe I can work through making it so one time passcodes are viable. I was going to use sqlite3, but I may press ahead and just use postgres. If I can do this, it would mean this tool could bolt in to any situation.

That's really nice, I hope you can make that happen!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants