Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix NPM issues causing errors #391

Closed
wants to merge 1 commit into from
Closed

Fix NPM issues causing errors #391

wants to merge 1 commit into from

Conversation

jnjerin
Copy link
Contributor

@jnjerin jnjerin commented Jul 3, 2023

This PR fixes some issues caused by npm by:

  • Removing unsupported test library for fabric that depends on packages that fail to compile
  • Bumps nodejs version from 12 to 16 at samples/chaincodes/chaincode-kv-node/.nvmrc
  • Removing non-crucial tests from the sample chaincode

@jnjerin
Apply patch to fix npm errors
4df591b 
Signed-off-by: jnjerin <njerijoan24@gmail.com>
@jnjerin
Copy link
Contributor Author

jnjerin commented Jul 3, 2023

Possible fix for #348

@jnjerin
Copy link
Contributor Author

jnjerin commented Jul 3, 2023

Possible fix for #328

@dzikowski
Copy link
Contributor

Will be resolved in #403

@dzikowski dzikowski closed this Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dzikowski dzikowski dzikowski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jnjerin @dzikowski