Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(test-tooling): fix CI job failing due to with wasm-pack #2407

Closed
sandeepnRES opened this issue Apr 27, 2023 · 4 comments · Fixed by #2527
Closed

ci(test-tooling): fix CI job failing due to with wasm-pack #2407

sandeepnRES opened this issue Apr 27, 2023 · 4 comments · Fixed by #2527
Assignees
@petermetz @adrianbatuto
Labels
bug Something isn't working dependencies Pull requests that update a dependency file Flaky-Test-Automation Issues related to test stability (which is a long running issue that can never fully be solved) P1 Priority 1: Highest rust Pull requests that update Rust code Tests Anything related to tests be that automatic or manual, integration or unit, etc.

Comments

@sandeepnRES
Copy link
Member

sandeepnRES commented Apr 27, 2023 •
edited
Loading

Describe the bug

cactus-test-tooling job which is marked as required for merge to main is consistently failing. On asking @jagpreetsinghsasan, he said this has something to do with wasm-pack not able to generate the nodejs files

To Reproduce

It is always reproducible, and can be checked on any open PR.

Expected behavior

Should succeed.

Logs/Stack traces

Here are the logs:
logs.txt
@sandeepnRES sandeepnRES added the bug Something isn't working label Apr 27, 2023
@sandeepnRES
Copy link
Member Author

@petermetz shall we remove this job from required so that it doesn't halt all the PRs? Or if there's a quick fix we can do it at priority. I'm fine with any choice

@sandeepnRES sandeepnRES changed the title fix(ci): cactus-test-tooling job is failing consistently due to issue with wasm-pack fix(ci): cactus-test-tooling job failing consistently due to issue with wasm-pack Apr 27, 2023
@petermetz
Copy link
Member

@petermetz shall we remove this job from required so that it doesn't halt all the PRs? Or if there's a quick fix we can do it at priority. I'm fine with any choice

@sandeepnRES Yeah, of course. Sorry I thought you had already removed it from the required list based on our last discussion on discord. I'll do it right now.

@petermetz petermetz added dependencies Pull requests that update a dependency file Flaky-Test-Automation Issues related to test stability (which is a long running issue that can never fully be solved) Tests Anything related to tests be that automatic or manual, integration or unit, etc. P1 Priority 1: Highest rust Pull requests that update Rust code labels Apr 27, 2023
@petermetz petermetz self-assigned this Apr 27, 2023
@adrianbatuto
Copy link
Contributor

Hi @petermetz, please assign this to me.

@petermetz
Copy link
Member

Hi @petermetz, please assign this to me.

@adrianbatuto Done, thank you very much!

adrianbatuto added a commit to adrianbatuto/cacti that referenced this issue Jun 29, 2023
@adrianbatuto
fix(ci): cactus-test-tooling job failing consistently due to issue wi…
1a71521 
…th wasm-pack

Fixes hyperledger#2407
@adrianbatuto adrianbatuto mentioned this issue Jun 29, 2023
Merged
adrianbatuto added a commit to adrianbatuto/cacti that referenced this issue Jun 29, 2023
@adrianbatuto
fix(ci): cactus-test-tooling job failing consistently due to issue wi…
e1129c5 
…th wasm-pack

Fixes hyperledger#2407

Signed-off-by: adrianbatuto <adrian.batuto@accenture.com>
@petermetz petermetz changed the title fix(ci): cactus-test-tooling job failing consistently due to issue with wasm-pack ci(test-tooling): fix CI job failing due to with wasm-pack Jun 30, 2023
adrianbatuto added a commit to adrianbatuto/cacti that referenced this issue Jul 4, 2023
@adrianbatuto
fix(ci): cactus-test-tooling job failing consistently due to issue wi…
5454e7a 
…th wasm-pack

Fixes hyperledger#2407

Signed-off-by: adrianbatuto <adrian.batuto@accenture.com>

ci(test-tooling): fix CI job failing due to with wasm-pack

Updated the cactus-rust-compiler version to properly build the image and get the required files.

Fixes hyperledger#2407

Signed-off-by: adrianbatuto <adrian.batuto@accenture.com>
adrianbatuto added a commit to adrianbatuto/cacti that referenced this issue Jul 4, 2023
@adrianbatuto
fix(ci): cactus-test-tooling job failing consistently due to issue wi…
4d62723 
…th wasm-pack

Fixes hyperledger#2407

Signed-off-by: adrianbatuto <adrian.batuto@accenture.com>

ci(test-tooling): fix CI job failing due to with wasm-pack

Updated the cactus-rust-compiler version to properly build the image and get the required files.

Fixes hyperledger#2407

Signed-off-by: adrianbatuto <adrian.batuto@accenture.com>
adrianbatuto added a commit to adrianbatuto/cacti that referenced this issue Jul 4, 2023
@adrianbatuto
ci(test-tooling): fix CI job failing due to with wasm-pack
f03838a 
Updated the cactus-rust-compiler version to properly build the image and get the required files.

Fixes hyperledger#2407

Signed-off-by: adrianbatuto <adrian.batuto@accenture.com>
petermetz pushed a commit to adrianbatuto/cacti that referenced this issue Jul 6, 2023
@adrianbatuto @petermetz
ci(test-tooling): fix CI job failing due to with wasm-pack
7e0ff6a 
Updated the cactus-rust-compiler version to properly build the image and get the required files.

Fixes hyperledger#2407

Signed-off-by: adrianbatuto <adrian.batuto@accenture.com>
petermetz pushed a commit that referenced this issue Jul 6, 2023
@adrianbatuto @petermetz
ci(test-tooling): fix CI job failing due to with wasm-pack
6d012c7 
Updated the cactus-rust-compiler version to properly build the image and get the required files.

Fixes #2407

Signed-off-by: adrianbatuto <adrian.batuto@accenture.com>
sandeepnRES pushed a commit to sandeepnRES/cacti that referenced this issue Dec 21, 2023
@adrianbatuto @sandeepnRES
ci(test-tooling): fix CI job failing due to with wasm-pack
69b88fa 
Updated the cactus-rust-compiler version to properly build the image and get the required files.

Fixes hyperledger#2407

Signed-off-by: adrianbatuto <adrian.batuto@accenture.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@petermetz petermetz

@adrianbatuto adrianbatuto

Labels
bug Something isn't working dependencies Pull requests that update a dependency file Flaky-Test-Automation Issues related to test stability (which is a long running issue that can never fully be solved) P1 Priority 1: Highest rust Pull requests that update Rust code Tests Anything related to tests be that automatic or manual, integration or unit, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ci(test-tooling): fix CI job failing due to with wasm-pack adrianbatuto/cacti
3 participants
@petermetz @sandeepnRES @adrianbatuto