Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2 implementation using fabric-protos-go-apiv2 #108

Merged
merged 2 commits into from
Jun 18, 2024

Conversation

bestbeforetoday
Copy link
Member

@bestbeforetoday bestbeforetoday commented Jun 1, 2024

The v2 implementation retains wire-level compatibility with Fabric but does include the following breaking changes:

  • Chaincode implementation that make direct use of fabric-protos-go will experience protocol buffer namespace conflicts (as described in https://protobuf.dev/reference/go/faq/). Any use of fabric-protos-go must be replaced by fabric-protos-go-apiv2.
  • The Chaincode interface and Stub now use only pointers to protocol buffer messages in their API. Chaincode implementation must provide matching Init and Invoke methods.

Closes #80

@bestbeforetoday bestbeforetoday force-pushed the fabric-protos-go-apiv2 branch 3 times, most recently from fa3b7f3 to 20d067a Compare June 1, 2024 14:49
@bestbeforetoday bestbeforetoday changed the title [WIP] v2 implementation using fabric-protos-go-apiv2 v2 implementation using fabric-protos-go-apiv2 Jun 1, 2024
@bestbeforetoday bestbeforetoday marked this pull request as ready for review June 1, 2024 14:54
@bestbeforetoday bestbeforetoday requested a review from a team as a code owner June 1, 2024 14:54
@bestbeforetoday bestbeforetoday force-pushed the fabric-protos-go-apiv2 branch 2 times, most recently from 0c95277 to 0aef6e9 Compare June 7, 2024 22:58
The v2 implementation retains wire-level compatibility with Fabric but
does include the following breaking changes:

- Chaincode implementation that make direct use of fabric-protos-go will
  experience protocol buffer namespace conflicts (as described in
  https://protobuf.dev/reference/go/faq/). Any use of fabric-protos-go
  must be replaced by fabric-protos-go-apiv2.
- The Chaincode interface and Stub now use only pointers to protocol buffer
  messages in their API. Chaincode implementation must provide matching
  Init and Invoke methods.

Signed-off-by: Mark S. Lewis <Mark.S.Lewis@outlook.com>
Signed-off-by: Mark S. Lewis <Mark.S.Lewis@outlook.com>
Copy link
Contributor

@denyeart denyeart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the approach of a separate v2 implementation. It is unfortunate that we need a 2nd copy of the code, but I guess that's life.

@denyeart denyeart merged commit f790332 into hyperledger:main Jun 18, 2024
4 checks passed
@bestbeforetoday bestbeforetoday deleted the fabric-protos-go-apiv2 branch June 18, 2024 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update from fabric-protos-go to fabric-protos-go-apiv2
2 participants