Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update fabric-proto-go dependency and tests #56

Merged
merged 1 commit into from
Jun 20, 2023

Conversation

MayRosenbaum
Copy link
Contributor

@MayRosenbaum MayRosenbaum commented Jun 14, 2023

Type of change

  • Bug fix
  • Test update

Description

update fabric-proto-go dependency, go version, and expected errors in tests

Related issues

#54

@MayRosenbaum MayRosenbaum requested a review from a team as a code owner June 14, 2023 11:26
@MayRosenbaum MayRosenbaum force-pushed the update_proto_go_dependency branch 5 times, most recently from b32692a to b60ac4d Compare June 14, 2023 12:30
@denyeart
Copy link
Contributor

@MayRosenbaum It is failing in lint:

exec ci/lint.sh
========================== Starting Command Output ===========================
/bin/bash --noprofile --norc /home/vsts/work/_temp/00ce4b37-e86c-43e0-ad79-28259986f221.sh
running goimports...
running gofumpt...
running go vet...
go: downloading github.com/golang/protobuf v1.5.2
go: downloading github.com/Knetic/govaluate v3.0.0+incompatible
go: downloading github.com/hyperledger/fabric-protos-go v0.3.0
go: downloading github.com/onsi/gomega v1.9.0
go: downloading google.golang.org/protobuf v1.28.1
go: downloading google.golang.org/grpc v1.46.2
go: downloading golang.org/x/net v0.0.0-20201021035429-f5854403a974
go: downloading google.golang.org/genproto v0.0.0-20200526211855-cb27e3aa2013
go: downloading gopkg.in/yaml.v2 v2.2.4
go: downloading golang.org/x/sys v0.0.0-20210119212857-b64e53b001e4
go: downloading golang.org/x/text v0.3.3
# github.com/hyperledger/fabric-config/configtx
configtx/signer_test.go:316:26: loop variable test captured by func literal
configtx/signer_test.go:316:37: loop variable test captured by func literal
##[error]Bash exited with code '1'.

@MayRosenbaum
Copy link
Contributor Author

@MayRosenbaum It is failing in lint:

exec ci/lint.sh
========================== Starting Command Output ===========================
/bin/bash --noprofile --norc /home/vsts/work/_temp/00ce4b37-e86c-43e0-ad79-28259986f221.sh
running goimports...
running gofumpt...
running go vet...
go: downloading github.com/golang/protobuf v1.5.2
go: downloading github.com/Knetic/govaluate v3.0.0+incompatible
go: downloading github.com/hyperledger/fabric-protos-go v0.3.0
go: downloading github.com/onsi/gomega v1.9.0
go: downloading google.golang.org/protobuf v1.28.1
go: downloading google.golang.org/grpc v1.46.2
go: downloading golang.org/x/net v0.0.0-20201021035429-f5854403a974
go: downloading google.golang.org/genproto v0.0.0-20200526211855-cb27e3aa2013
go: downloading gopkg.in/yaml.v2 v2.2.4
go: downloading golang.org/x/sys v0.0.0-20210119212857-b64e53b001e4
go: downloading golang.org/x/text v0.3.3
# github.com/hyperledger/fabric-config/configtx
configtx/signer_test.go:316:26: loop variable test captured by func literal
configtx/signer_test.go:316:37: loop variable test captured by func literal
##[error]Bash exited with code '1'.

Im working on it

@MayRosenbaum MayRosenbaum force-pushed the update_proto_go_dependency branch 2 times, most recently from 4bca07a to 5530637 Compare June 19, 2023 08:14
Signed-off-by: May Rosenbaum <mayro1595@gmail.com>
@tock-ibm tock-ibm merged commit 88e418e into hyperledger:main Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants