Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2 implementation based on fabric-chaincode-go/v2 #137

Merged

Conversation

bestbeforetoday
Copy link
Member

@bestbeforetoday bestbeforetoday commented Jun 19, 2024

The v2 implementation retains wire-level compatibility with Fabric but does include the following breaking changes:

  • Chaincode implementations that make direct use of github.com/hyperledger/fabric-protos-go will experience protocol buffer namespace conflicts (as described in https://protobuf.dev/reference/go/faq/). Any use of fabric-protos-go must be replaced by github.com/hyperledger/fabric-protos-go-apiv2.
  • In order to avoid an indirect dependency on fabric-protos-go, chaincode implementations that make direct use of github.com/hyperledger/fabric-chaincode-go must instead use github.com/hyperledger/fabric-chaincode-go/v2.

Closes #102

@bestbeforetoday bestbeforetoday force-pushed the fabric-protos-go-apiv2 branch 10 times, most recently from 3ef6cc9 to 44cc73c Compare June 19, 2024 19:06
The v2 implementation retains wire-level compatibility with Fabric but
does include the following breaking changes:

- Chaincode implementations that make direct use of fabric-protos-go
  will experience protocol buffer namespace conflicts (as described in
  https://protobuf.dev/reference/go/faq/). Any use of fabric-protos-go
  must be replaced by fabric-protos-go-apiv2.

Signed-off-by: Mark S. Lewis <Mark.S.Lewis@outlook.com>
@bestbeforetoday bestbeforetoday marked this pull request as ready for review June 19, 2024 20:00
@bestbeforetoday bestbeforetoday requested a review from a team as a code owner June 19, 2024 20:00
@bestbeforetoday bestbeforetoday enabled auto-merge (squash) June 19, 2024 20:00
@bestbeforetoday bestbeforetoday merged commit b8b28e7 into hyperledger:main Jun 20, 2024
12 checks passed
@bestbeforetoday bestbeforetoday deleted the fabric-protos-go-apiv2 branch June 20, 2024 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update from fabric-protos-go to fabric-protos-go-apiv2
1 participant