Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor block event tests #760

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Refactor block event tests #760

wants to merge 2 commits into from

Commits on Oct 7, 2024

  1. Update fabric-protos 

    New version of fabric-protos uses updated protoc and protobuf versions,
including protobuf-java v4. This change updates from protobuf-java v3 to
v4.

The change to use generics in the newer generated gRPC client stubs
means that the previous approach of mocking them using uber-go/mock is
not possible. This change uses mockery to mock the gRPC client
connection instead. Mockery does support mocking of most generics, and
mocking at the connection allows unit testing to be done using the
public API without test hooks to allow replacement of gRPC stubs.

Signed-off-by: Mark S. Lewis <Mark.S.Lewis@outlook.com>
    @bestbeforetoday
    bestbeforetoday committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    2ed475f View commit details
    Browse the repository at this point in the history

  2. Refactor block eventing unit tests 

    Simplify tests by using an abstraction to the eventing set up and
invocation so that a set of common tests can be applied to block,
filtered block, and block and private data unit tests.

Signed-off-by: Mark S. Lewis <Mark.S.Lewis@outlook.com>
    @bestbeforetoday
    bestbeforetoday committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    861540f View commit details
    Browse the repository at this point in the history