Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Org3cli and configtx.yaml anchor peers from test-network #401

Merged
merged 2 commits into from
Jan 11, 2021

Conversation

wlahti
Copy link
Contributor

@wlahti wlahti commented Jan 7, 2021

Type of change

  • Improvement

Description

First commit:

Second commit:

  • Remove anchor peers from configtx.yaml's anchor peers. These values were only used by configtxgen's --outputAnchorPeerUpdate function and should not be set in a channel genesis block This is because a peer cannot be an anchor peer for a channel until it has joined that channel and it can't join a channel until the genesis block has been created.

Related issues

FAB-18381

FAB-18381

Signed-off-by: Will Lahti <wtlahti@us.ibm.com>
@wlahti wlahti requested a review from a team as a code owner January 7, 2021 19:23
These values were only used by configtxgen's --outputAnchorPeerUpdate
function and should not be set in a channel genesis block This is because
a peer cannot be an anchor peer for a channel until it has joined that
channel and it can't join a channel until the genesis block has been
created.

FAB-18381

Signed-off-by: Will Lahti <wtlahti@us.ibm.com>
@wlahti wlahti changed the title Remove Org3cli from test-network Remove Org3cli and configtx.yaml anchor peers from test-network Jan 9, 2021
Copy link
Contributor

@nikhil550 nikhil550 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. However, lets merge this cherry pick to the release 2.2 docs before we merge.

@nikhil550
Copy link
Contributor

lets merge this cherry pick to the release 2.2 docs before we merge: hyperledger/fabric#2256

@nikhil550 nikhil550 merged commit 9b8f50e into hyperledger:master Jan 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants