Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FABG-961] Use system cert pool when connecting to fabric-ca #69

Merged
merged 1 commit into from
Apr 15, 2020

Conversation

alikic
Copy link
Contributor

@alikic alikic commented Apr 14, 2020

When client.tlsCerts.systemCertPool is set to true,
TLS connections to fabric-ca instances now use system
cert pool. There is no need to have tlsCACerts.path
defined in CAs' configurations in that case.

Signed-off-by: Aleksandar Likic aleksandar.likic@securekey.com

@alikic alikic requested a review from a team as a code owner April 14, 2020 22:56
@codecov
Copy link

codecov bot commented Apr 14, 2020

Codecov Report

Merging #69 into master will increase coverage by 0.07%.
The diff coverage is 79.38%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #69      +/-   ##
==========================================
+ Coverage   74.61%   74.69%   +0.07%     
==========================================
  Files         185      188       +3     
  Lines       12901    12999      +98     
==========================================
+ Hits         9626     9709      +83     
- Misses       2327     2338      +11     
- Partials      948      952       +4     
Impacted Files Coverage Δ
pkg/fab/opts.go 100.00% <ø> (ø)
pkg/msp/identityconfig.go 78.66% <68.88%> (-1.23%) ⬇️
pkg/core/mocks/mockconfigbackend.go 80.43% <86.04%> (ø)
pkg/core/config/comm/tls/certpool.go 82.60% <100.00%> (ø)
pkg/fab/endpointconfig.go 82.50% <100.00%> (ø)
pkg/msp/fabcaadapter.go 71.87% <100.00%> (+0.32%) ⬆️
pkg/msp/opts.go 90.47% <100.00%> (+0.47%) ⬆️
pkg/core/mocks/mocksigningmgr.go 0.00% <0.00%> (ø)
pkg/core/mocks/mockcorecontext.go 0.00% <0.00%> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e550fc...9f3b031. Read the comment docs.

When client.tlsCerts.systemCertPool is set to true,
TLS connections to fabric-ca instances now use system
cert pool. There is no need to have tlsCACerts.path
defined in CAs' configurations in that case.

Signed-off-by: Aleksandar Likic <aleksandar.likic@securekey.com>
@alikic alikic merged commit 60484dd into hyperledger:master Apr 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants