Socket connection fix: destroy() used instead of abort() #674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rajat Sharma <Rajat16.Sharma@ril.com> Signed-off-by: Akshat Khandelwal <akshat.khandelwal@ril.com>
|
This is the fix I was mentioning. This has really helped our team in case of high load on the CA. Issue: #672 |
bestbeforetoday
approved these changes
May 12, 2023
This was referenced Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While testing the
fabric-node-SDK, found that the connections were not getting reused creating more connections in the pool.While debugging the issue further found that the issue is the connection was not getting destroyed. The
request.abort()method was deprecated for a really long time too, so it makes sense this could be changed.Thus, this minor code change fixes this issue and we're able to decrease the number of active GRPC connections on the network.