Skip to content

Commit

Permalink
Remove discovery.acl principal warning
Browse files Browse the repository at this point in the history
PR #3006 added warnings for principal check failures to assist with troubleshooting.
The discovery warning was too much however since even in normal scenarios
discovery endorser service checks the peer against the various channel principals.
This change reverts to the prior code without the warning.

Resolves hyperledger/fabric-gateway#349.

Signed-off-by: David Enyeart <enyeart@us.ibm.com>
(cherry picked from commit 0b0c35c)
  • Loading branch information
denyeart committed Dec 13, 2021
1 parent e0bb139 commit 1f87709
Showing 1 changed file with 1 addition and 5 deletions.
6 changes: 1 addition & 5 deletions discovery/support/acl/support.go
Original file line number Diff line number Diff line change
Expand Up @@ -99,11 +99,7 @@ func (s *DiscoverySupport) SatisfiesPrincipal(channel string, rawIdentity []byte
logger.Warnw("failed deserializing identity", "error", err, "identity", protoutil.LogMessageForSerializedIdentity(rawIdentity))
return errors.Wrap(err, "failed deserializing identity")
}
err = identity.SatisfiesPrincipal(principal)
if err != nil {
logger.Warnw("identity does not satisfy principal", "error", err, "requiredPrincipal", principal, "identity", protoutil.LogMessageForSerializedIdentity(rawIdentity))
}
return err
return identity.SatisfiesPrincipal(principal)
}

// ChannelPolicyManagerGetter is a support interface
Expand Down

0 comments on commit 1f87709

Please sign in to comment.