Skip to content

Commit

Permalink
[FAB-18521] Fixing flaky IT, send remove tx to another node (#2761)
Browse files Browse the repository at this point in the history
PR #2748, introduced new IT to ensure the fix. However, there is some
flakiness manifested with this IT, caused by sending the remove
consenter transaction to the "to be removed" node. Removing
the consenter is a config transaction where codes after sending it
ensure a new block with the config update successfully committed,
which is the root cause for the flakiness. Once OSN is removed from
the channel, it no longer can server deliver requests for clients
trying to fetch from it.

This commit, fixes it by sending remove OSN config updated transaction
to a different node instead.

Signed-off-by: Artem Barger <artem@bargr.net>
  • Loading branch information
C0rWin authored Jul 17, 2021
1 parent 44ab2bf commit ffe7d36
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions integration/raft/cft_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -329,8 +329,6 @@ var _ = Describe("EndToEnd Crash Fault Tolerance", func() {
}, orderers, peer, network)

By("Removing OSN from the channel")
removeConsenter(network, peer, victim, "systemchannel", victimCertBytes)

remainedOrderers := []*nwo.Orderer{}
remainedRunners := []*ginkgomon.Runner{}

Expand All @@ -342,6 +340,9 @@ var _ = Describe("EndToEnd Crash Fault Tolerance", func() {
remainedRunners = append(remainedRunners, ordererRunners[i])
}

removeConsenter(network, peer, remainedOrderers[0], "systemchannel", victimCertBytes)

By("Asserting all remaining nodes got last block")
assertBlockReception(map[string]int{
"systemchannel": 2,
}, remainedOrderers, peer, network)
Expand Down

0 comments on commit ffe7d36

Please sign in to comment.