-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gateway documentation #2807
Comments
I don't think we should couple SD and GW. The gateway feature is big enough to deserve its own page. Of course, it makes sense to link to the gateway from the service discovery and vice versa, but let's not create technical confusion. |
You can remove your emoji now! |
|
@denyeart Can you confirm the tutorials text - seems odd that the CLI would not use gateway. Or are we saying that CLI does not access the gateway for THIS command / examples. |
@joshhus CLI should ideally use gateway, but updating the CLI has not been prioritized yet. Your first link is the main fabric docs source that generates ReadTheDocs. |
I don't seem to have access to check boxes. Tutorials done. Gateway overview done or close to it. |
@denyeart I suggested some clarifications for your follow on PR - 2 comments - #3047 |
@joshhus I answered your direct question in #3407. Please go ahead with any subsequent edits in another follow-on PR. |
@denyeart @andrew-coleman Another page to get a redo for for 2.4 gateway - https://hyperledger-fabric.readthedocs.io/en/release-2.3/txflow.html?highlight=transaction%20flow . ... With images. |
|
New hyperledger fabric developer feedback - I am totally confused between 2.4 Fabric Gateway and the previous gateway references.
It would appear there are 3 references to 3 different "gateway" code or design elements. Clarity in documentation would be very much appreciated, especially if older versions can not be retroactively changed to remove overloaded references. |
@jonmchan The documentation is still being reworked following the release of Fabric v2.4, including the Fabric Gateway service. Developing Applications is one of the pieces not yet updated. Feedback on where it is deficient (and it is!) is welcome; as are contributions. Do these updated pages make things any clearer around Fabric Gateway and the application APIs? |
@bestbeforetoday thanks for the reply. The updated pages provide limited clarity on the topic for me. Yes, through the documentation, I understand the gateway abstracts away from the client having to know which peers to connect and exposes Open questions and state of learning discovery for this new hyperledger fabric developer: What becomes of all the connection profiles and setup mentioned in https://hyperledger-fabric.readthedocs.io/en/latest/developapps/gateway.html? It would appear from the RFC that fabric-gateway-java is indeed related to Fabric Gateway as mentioned in prior art https://hyperledger.github.io/fabric-rfcs/text/0000-fabric-gateway.html#prior-art? Is this the same project? Does the fabric-gateway-java become deprecated or are they independent methodologies of achieving the same thing? |
imho, one of the biggest causes of confusion is the name overload for "fabric-gateway". The new 2.4 integrated Fabric Gateway is exactly the same as the 1.4 external fabric-gateway which makes google searching extremely confusing and frustrating - it's not like these 2 things are different - they're both implementations of a gateway system so you can't even tell from reading the context. The original poster "Peer Gateway" vs "SDK Gateway" terminology needs to be highlighted and utilized as much as possible. |
@jonmchan The tutorial for running a Fabric application has now been updated, and steps through set up and running one of the samples in the fabric-samples repository that uses the new application API: https://hyperledger-fabric.readthedocs.io/en/latest/write_first_app.html Does this help? |
@jonmchan The two documentation pages I linked to earlier should answer your question on how the fabric-gateway and fabric-gateway-java APIs relate to each other. For example, the Fabric Contract APIs and Application APIs page refers and links to the fabric-gateway API as "the preferred API for developing applications for Fabric v2.4 onwards", whereas it refers and links to the fabric-gateway-java SDK as "Legacy application SDKs [that] support versions of Fabric prior to v2.4, and do not require the Gateway peer capability." Specific suggestions for what to say where to make things clearer are welcome. |
@bestbeforetoday i'll go through the tutorial and leave feedback - this looks like it might be exactly what I'm looking for. In terms of specific suggestions, since the documentation is very large and spans multiple pages, having a note on https://hyperledger-fabric.readthedocs.io/en/latest/developapps/gateway.html and https://hyperledger-fabric.readthedocs.io/en/latest/gateway.html may be useful for those directly going to those pages and not browsing the entire documentation. Alternatively, could the gateway pages be consolidated? Thank you. |
@joshhus sure - i'd be interested in participating. Keep me posted. Thank you. |
Closing this item in favor of individual issues for the remaining subtasks.
|
Terminology
Top Priorities (Dave)
Top priorities (Mark)
Top priorities (Andy)
Top priorities (Josh with guidance from Andy)
Top priorities (Chris with guidance from Andy and Mark)
Key Concepts - Private data (Andy)
Other Key Concept topics (Josh)
Tutorials (Josh)
FAQ - minor edits required (Dave)
Developing Applications and Commercial Paper tutorial (Andy/Mark/Matthew/James)
The text was updated successfully, but these errors were encountered: