Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

peers doc iteration #3077

Closed
wants to merge 1 commit into from
Closed

peers doc iteration #3077

wants to merge 1 commit into from

Conversation

joshhus
Copy link
Contributor

@joshhus joshhus commented Nov 24, 2021

Signed-off-by: Josh Horton joshh@us.ibm.com

Type of change

  • New feature
  • Documentation update

Description

Another iteration on the Peers topic for new Fabric Gateway service.

Related issues

#2807

Signed-off-by: Josh Horton <joshh@us.ibm.com>
@joshhus joshhus requested review from a team as code owners November 24, 2021 23:46
@joshhus
Copy link
Contributor Author

joshhus commented Nov 25, 2021

So the "issue" with this page/topic is that it was originally written for Peers, and then goes through the relationship in detail of a Peer to EACH other element in a Fabric channel. Hence, the sense of duplication across this very long page/topic regardless of the gateway service adds. Especially in the later Orderers and Peers section, which is very long. I cleaned up that section e2e, BUT also left the Phase 1, 2, 3 discussions in there. ... With Phase 1, 2, 3 discussions ALSO in the previous Applications and Peers section, there remains some duplication - albeit from different perspectives (Apps vs. Orderers).

So rather than just delete legacy text - Orderers and Peers does have some interesting comments in there about security for example - I suggest we leave what I left in for Monday without further re-strategizing the entire page/topic. (But I have deleted substantial parts, such as those on determinism, per the review.)

In summary, the whole Peers page has gotten my e2e today and I think it's pretty good for Monday. Notable exception being the missing graphics for Figures 6 and 10, which are commented out for now. I'll read it again Friday in the formatted view to be sure of all details, and can do another PR per you reviews as necessary.

@denyeart denyeart changed the title peers iteration peers doc iteration Nov 25, 2021
@denyeart
Copy link
Contributor

@joshhus No changes are reflected in this PR!

@joshhus
Copy link
Contributor Author

joshhus commented Nov 27, 2021

Replaced by #3079

@joshhus joshhus closed this Nov 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants