Use directly leveldb batch #1507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit improves the leveldbhelper.UpdateBatch by replacing the map that it maintains by the actual leveldb batch. This reduces the memory consumed and a sorting of key-values is avoided if the data added is already in sorted order (such as loading the data from snapshot files) Signed-off-by: manish <manish.sethi@gmail.com>
cendhu
approved these changes
Jul 1, 2020
| // WriteBatch writes a batch in an atomic way | ||
| func (h *DBHandle) WriteBatch(batch *UpdateBatch, sync bool) error { | ||
| if len(batch.KVs) == 0 { | ||
| if batch == nil || batch.Len() == 0 { |
There was a problem hiding this comment.
Not related to this PR. I was checking whether leveldb.WriteBatch returns err when the batch is nil (it does). You might be aware of the following. Then, I found that they use transaction (OpenTransaction(), Commit()) when the batch size is large to skip writing to journal. I remember once you said that we need to look at disabling the journal writes as we have a block store.
|
@Mergifyio backport release-2.2 |
|
Command
|
mergify bot
pushed a commit
that referenced
this pull request
Sep 8, 2020
This commit improves the leveldbhelper.UpdateBatch by replacing the map that it maintains by the actual leveldb batch. This reduces the memory consumed and a sorting of key-values is avoided if the data added is already in sorted order (such as loading the data from snapshot files) Signed-off-by: manish <manish.sethi@gmail.com> (cherry picked from commit 1ad6d5b)
cendhu
pushed a commit
to cendhu/fabric
that referenced
this pull request
Sep 8, 2020
This commit improves the leveldbhelper.UpdateBatch by replacing the map that it maintains by the actual leveldb batch. This reduces the memory consumed and a sorting of key-values is avoided if the data added is already in sorted order (such as loading the data from snapshot files) Signed-off-by: manish <manish.sethi@gmail.com>
ale-linux
pushed a commit
that referenced
this pull request
Sep 8, 2020
This commit improves the leveldbhelper.UpdateBatch by replacing the map that it maintains by the actual leveldb batch. This reduces the memory consumed and a sorting of key-values is avoided if the data added is already in sorted order (such as loading the data from snapshot files) Signed-off-by: manish <manish.sethi@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: manish manish.sethi@gmail.com
Type of change
Description
This PR improves the
leveldbhelper.UpdateBatchby replacing the map that it maintains by the actual leveldb batch.This reduces the memory consumed and a sorting of key-values is avoided if the data added is already in sorted order (such as loading the data from snapshot files)