FAB-18276 Ch.Part.API: extractSystemChannel must skip empty ledger #2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- orderer/common/server/main.go extractSystemChannel() panics when it hits an empty ledger. - In addition this method is not covered with unit tests at all. - Remove some dead code. Signed-off-by: Yoav Tock <tock@il.ibm.com> Change-Id: Ie13156784d2ec600e3f97d34f20f6836b28f7662
ale-linux
approved these changes
Oct 19, 2020
Param-S
pushed a commit
to Param-S/fabric
that referenced
this pull request
Jun 7, 2021
…yperledger#2023) - orderer/common/server/main.go extractSystemChannel() panics when it hits an empty ledger. - In addition this method is not covered with unit tests at all. - Remove some dead code. Signed-off-by: Yoav Tock <tock@il.ibm.com> Change-Id: Ie13156784d2ec600e3f97d34f20f6836b28f7662
manish-sethi
pushed a commit
that referenced
this pull request
Jun 7, 2021
…2648) * FAB-18276 Ch.Part.API: extractSystemChannel must skip empty ledger (#2023) - orderer/common/server/main.go extractSystemChannel() panics when it hits an empty ledger. - In addition this method is not covered with unit tests at all. - Remove some dead code. Signed-off-by: Yoav Tock <tock@il.ibm.com> Change-Id: Ie13156784d2ec600e3f97d34f20f6836b28f7662 * Added RetrieveBlockByNumber into blockledger (#2635) GetBlock is used for retrieving a block in ConfigBlockOrPanic which has overhead of Iterator. It is now simplified by exposing a BlockStore function RetrieveBlockByNumber. Signed-off-by: Parameswaran Selvam <parselva@in.ibm.com> Co-authored-by: Yoav Tock <tock@il.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
orderer/common/server/main.go extractSystemChannel() panics when
it hits an empty ledger.
In addition this method is not covered with unit tests at all.
Remove some dead code.
Signed-off-by: Yoav Tock tock@il.ibm.com
Change-Id: Ie13156784d2ec600e3f97d34f20f6836b28f7662
Type of change
Related issues
Issue: FAB-18276
Epic: FAB-17712