Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add peer log message for failure to invoke chaincode #2339

Merged
merged 1 commit into from
Feb 2, 2021

Conversation

denyeart
Copy link
Contributor

@denyeart denyeart commented Feb 2, 2021

When looking in peer log to troubleshoot chaincode invocations,
there is currently no difference between a successful
invocation and a failure to execute, they all get logged as a successful ProcessProposal call.
This change adds a log Warning with error message for each failure to invoke.

Signed-off-by: David Enyeart enyeart@us.ibm.com

When looking in peer log to troubleshoot chaincode invocations,
there is currently no difference between a successful
invocation and a failure to execute, they all look successful.
This change adds a log Warning with error message for each failure to invoke.

Signed-off-by: David Enyeart <enyeart@us.ibm.com>
@denyeart denyeart requested a review from a team as a code owner February 2, 2021 17:57
@yacovm yacovm merged commit 4e74441 into hyperledger:master Feb 2, 2021
@denyeart denyeart deleted the process_proposal_error branch February 2, 2021 18:32
@denyeart
Copy link
Contributor Author

denyeart commented Feb 2, 2021

@Mergifyio backport release-2.3

@denyeart
Copy link
Contributor Author

denyeart commented Feb 2, 2021

@Mergifyio backport release-2.2

mergify bot pushed a commit that referenced this pull request Feb 2, 2021
When looking in peer log to troubleshoot chaincode invocations,
there is currently no difference between a successful
invocation and a failure to execute, they all look successful.
This change adds a log Warning with error message for each failure to invoke.

Signed-off-by: David Enyeart <enyeart@us.ibm.com>

Co-authored-by: David Enyeart <denyeart@Davids-MBP.nc.rr.com>
(cherry picked from commit 4e74441)
@mergify
Copy link

mergify bot commented Feb 2, 2021

Command backport release-2.3: success

Backports have been created

mergify bot pushed a commit that referenced this pull request Feb 2, 2021
When looking in peer log to troubleshoot chaincode invocations,
there is currently no difference between a successful
invocation and a failure to execute, they all look successful.
This change adds a log Warning with error message for each failure to invoke.

Signed-off-by: David Enyeart <enyeart@us.ibm.com>

Co-authored-by: David Enyeart <denyeart@Davids-MBP.nc.rr.com>
(cherry picked from commit 4e74441)
@mergify
Copy link

mergify bot commented Feb 2, 2021

Command backport release-2.2: success

Backports have been created

denyeart added a commit that referenced this pull request Feb 2, 2021
When looking in peer log to troubleshoot chaincode invocations,
there is currently no difference between a successful
invocation and a failure to execute, they all look successful.
This change adds a log Warning with error message for each failure to invoke.

Signed-off-by: David Enyeart <enyeart@us.ibm.com>

Co-authored-by: David Enyeart <denyeart@Davids-MBP.nc.rr.com>
(cherry picked from commit 4e74441)
denyeart added a commit that referenced this pull request Feb 2, 2021
When looking in peer log to troubleshoot chaincode invocations,
there is currently no difference between a successful
invocation and a failure to execute, they all look successful.
This change adds a log Warning with error message for each failure to invoke.

Signed-off-by: David Enyeart <enyeart@us.ibm.com>

Co-authored-by: David Enyeart <denyeart@Davids-MBP.nc.rr.com>
(cherry picked from commit 4e74441)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants