Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optionally disable gossip block forwarding #2606

Merged
merged 1 commit into from
May 25, 2021
Merged

Optionally disable gossip block forwarding #2606

merged 1 commit into from
May 25, 2021

Conversation

yacovm
Copy link
Contributor

@yacovm yacovm commented May 25, 2021 •
edited
Loading

This commit adds a new configuration option to the peer which makes peers
not forward blocks that they pull from the ordering service.

If all peers in an organization explictly set "peer.deliveryclient.blockGossipEnabled" to false,
no peer in the organization gossips blocks to any other peer in that organization.

Change-Id: I5d9b278ae72f239129827c044fa78179f6ba87ab
Signed-off-by: Yacov Manevich yacovm@il.ibm.com

@yacovm yacovm requested a review from a team as a code owner May 25, 2021 20:11
@yacovm yacovm force-pushed the disableOrgBlockDissemination branch 2 times, most recently from 38154a4 to 0e06429 Compare May 25, 2021 20:24
denyeart
denyeart reviewed May 25, 2021
View reviewed changes
sampleconfig/core.yaml Outdated Show resolved Hide resolved
@yacovm yacovm force-pushed the disableOrgBlockDissemination branch 2 times, most recently from f67fc74 to 8dd8d25 Compare May 25, 2021 21:01
C0rWin
C0rWin previously approved these changes May 25, 2021
View reviewed changes
denyeart
denyeart previously approved these changes May 25, 2021
View reviewed changes
@yacovm yacovm dismissed stale reviews from denyeart and C0rWin via 4e72d74 May 25, 2021 21:22
@yacovm yacovm force-pushed the disableOrgBlockDissemination branch from 8dd8d25 to 4e72d74 Compare May 25, 2021 21:22
@yacovm
Optionally disable gossip block forwarding
d6c0ede 
This commit adds a new configuration option to the peer which makes peers
not forward blocks that they pull from the ordering service.

If all peers in an organization explicitly set "peer.deliveryclient.blockGossipEnabled" to false,
no peer in the organization gossips blocks to any other peer in that organization.

Change-Id: I5d9b278ae72f239129827c044fa78179f6ba87ab
Signed-off-by: Yacov Manevich <yacovm@il.ibm.com>
@yacovm yacovm force-pushed the disableOrgBlockDissemination branch from 4e72d74 to d6c0ede Compare May 25, 2021 21:46
@yacovm yacovm enabled auto-merge (squash) May 25, 2021 22:15
@yacovm yacovm merged commit 4e201af into hyperledger:main May 25, 2021
@denyeart
Copy link
Contributor

@Mergifyio backport release-2.3

@denyeart
Copy link
Contributor

@Mergifyio backport release-2.2

@mergify mergify bot mentioned this pull request May 26, 2021
Merged
@mergify
Copy link

mergify bot commented May 26, 2021

Command backport release-2.3: success

Backports have been created

mergify bot pushed a commit that referenced this pull request May 26, 2021
@yacovm
Optionally disable gossip block forwarding (#2606)
19dcb11 
This commit adds a new configuration option to the peer which makes peers
not forward blocks that they pull from the ordering service.

If all peers in an organization explicitly set "peer.deliveryclient.blockGossipEnabled" to false,
no peer in the organization gossips blocks to any other peer in that organization.

Change-Id: I5d9b278ae72f239129827c044fa78179f6ba87ab
Signed-off-by: Yacov Manevich <yacovm@il.ibm.com>
(cherry picked from commit 4e201af)
mergify bot pushed a commit that referenced this pull request May 26, 2021
@yacovm
Optionally disable gossip block forwarding (#2606)
6d8e453 
This commit adds a new configuration option to the peer which makes peers
not forward blocks that they pull from the ordering service.

If all peers in an organization explicitly set "peer.deliveryclient.blockGossipEnabled" to false,
no peer in the organization gossips blocks to any other peer in that organization.

Change-Id: I5d9b278ae72f239129827c044fa78179f6ba87ab
Signed-off-by: Yacov Manevich <yacovm@il.ibm.com>
(cherry picked from commit 4e201af)
@mergify mergify bot mentioned this pull request May 26, 2021
Merged
@mergify
Copy link

mergify bot commented May 26, 2021

Command backport release-2.2: success

Backports have been created

C0rWin pushed a commit that referenced this pull request May 26, 2021
@yacovm @C0rWin
Optionally disable gossip block forwarding (#2606)
38f4713 
This commit adds a new configuration option to the peer which makes peers
not forward blocks that they pull from the ordering service.

If all peers in an organization explicitly set "peer.deliveryclient.blockGossipEnabled" to false,
no peer in the organization gossips blocks to any other peer in that organization.

Change-Id: I5d9b278ae72f239129827c044fa78179f6ba87ab
Signed-off-by: Yacov Manevich <yacovm@il.ibm.com>
(cherry picked from commit 4e201af)
C0rWin pushed a commit that referenced this pull request May 26, 2021
@yacovm @C0rWin
Optionally disable gossip block forwarding (#2606)
7871c26 
This commit adds a new configuration option to the peer which makes peers
not forward blocks that they pull from the ordering service.

If all peers in an organization explicitly set "peer.deliveryclient.blockGossipEnabled" to false,
no peer in the organization gossips blocks to any other peer in that organization.

Change-Id: I5d9b278ae72f239129827c044fa78179f6ba87ab
Signed-off-by: Yacov Manevich <yacovm@il.ibm.com>
(cherry picked from commit 4e201af)
pfi79 added a commit to scientificideas/fabric that referenced this pull request Apr 9, 2022
@pfi79
Optionally disable gossip block forwarding (hyperledger#2606)
2861c4b 
This commit adds a new configuration option to the peer which makes peers
not forward blocks that they pull from the ordering service.

If all peers in an organization explicitly set "peer.deliveryclient.blockGossipEnabled" to false,
no peer in the organization gossips blocks to any other peer in that organization.

Change-Id: I5d9b278ae72f239129827c044fa78179f6ba87ab
Signed-off-by: Yacov Manevich <yacovm@il.ibm.com>
(cherry picked from commit 4e201af)

# Conflicts:
#	core/deliverservice/deliveryclient.go
pfi79 added a commit to scientificideas/fabric that referenced this pull request Apr 9, 2022
@pfi79
Optionally disable gossip block forwarding (hyperledger#2606)
87cfe89 
This commit adds a new configuration option to the peer which makes peers
not forward blocks that they pull from the ordering service.

If all peers in an organization explicitly set "peer.deliveryclient.blockGossipEnabled" to false,
no peer in the organization gossips blocks to any other peer in that organization.

Change-Id: I5d9b278ae72f239129827c044fa78179f6ba87ab
Signed-off-by: Yacov Manevich <yacovm@il.ibm.com>
(cherry picked from commit 4e201af)

# Conflicts:
#	core/deliverservice/deliveryclient.go
C0rWin pushed a commit to C0rWin/fabric that referenced this pull request Sep 24, 2022
@yacovm @AllFi
Optionally disable gossip block forwarding (hyperledger#2606)
58e6bcf 
This commit adds a new configuration option to the peer which makes peers
not forward blocks that they pull from the ordering service.

If all peers in an organization explicitly set "peer.deliveryclient.blockGossipEnabled" to false,
no peer in the organization gossips blocks to any other peer in that organization.

Change-Id: I5d9b278ae72f239129827c044fa78179f6ba87ab
Signed-off-by: Yacov Manevich <yacovm@il.ibm.com>
(cherry picked from commit 4e201af)
joshua-roberts pushed a commit to usnistgov/redledger-fabric that referenced this pull request Nov 4, 2022
@yacovm @joshua-roberts
Optionally disable gossip block forwarding (hyperledger#2606)
4c91688 
This commit adds a new configuration option to the peer which makes peers
not forward blocks that they pull from the ordering service.

If all peers in an organization explicitly set "peer.deliveryclient.blockGossipEnabled" to false,
no peer in the organization gossips blocks to any other peer in that organization.

Change-Id: I5d9b278ae72f239129827c044fa78179f6ba87ab
Signed-off-by: Yacov Manevich <yacovm@il.ibm.com>
(cherry picked from commit 4e201af)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@C0rWin C0rWin C0rWin approved these changes

@denyeart denyeart denyeart left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yacovm @denyeart @C0rWin